gh-126662: naming consistency for signal.ItimerError #126712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
approved these changes
Nov 22, 2024
Member
There was a problem hiding this comment.
FWIW, this is a slight breaking change, but I don't think anyone was relying on this buggy behavior anyway.
erlend-aasland
approved these changes
Nov 29, 2024
kumaraditya303
approved these changes
Jul 26, 2025
|
Thanks @tungol for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 26, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 26, 2025
|
GH-137122 is a backport of this pull request to the 3.14 branch. |
|
GH-137123 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 27, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
vstinner
pushed a commit
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR updates the
__name__attribute of signal.ItimerError to match its import path. Let me know if a NEWS entry is needed for this; I was on the fence about it.