8000 gh-126606: don't write incomplete pyc files by cfbolz · Pull Request #126627 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-126606: don't write incomplete pyc files #126627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 13, 2024
Merged

gh-126606: don't write incomplete pyc files #126627

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3746297
check that the pyc file is fully written in _write_atomic
cfbolz Nov 9, 2024
c87d9bb
add news
cfbolz Nov 9, 2024
2c07d2b
Update Misc/NEWS.d/next/Core_and_Builtins/2024-11-09-16-10-22.gh-issu…
cfbolz Nov 9, 2024
50f2168
add parens to error, add comment why I'm using an OSError
cfbolz Nov 13, 2024
bffdc02
improve test:
cfbolz Nov 13, 2024
3852b32
Merge branch 'main' into gh-126606-dont-write-incomplete-pyc-files
brettcannon Nov 13, 2024
15b23b5
Tweak a comment
brettcannon Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add parens to error, add comment why I'm using an OSError
  • Loading branch information
@cfbolz
cfbolz committed Nov 13, 2024
commit 50f21680a120eb993c51566bd87f4e0d7c9c1b46
4 changes: 3 additions & 1 deletion Lib/importlib/_bootstrap_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,9 @@ def _write_atomic(path, data, mode=0o666):
with _io.FileIO(fd, 'wb') as file:
bytes_written = file.write(data)
if bytes_written != len(data):
raise OSError("os.write didn't write the full pyc file")
# Raise an OSError so the except below cleans up the partially
# written file.
raise OSError("os.write() didn't write the full pyc file")
_os.replace(path_tmp, path)
except OSError:
try:
Expand Down
0