8000 gh-126624: Expose error code ``XML_ERROR_NOT_STARTED`` of Expat >=2.6.4 by hartwork · Pull Request #126625 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-126624: Expose error code XML_ERROR_NOT_STARTED of Expat >=2.6.4 #126625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your 8000 account

Jump to bottom
Merged
merged 3 commits into from
Jan 2, 2025
Merged

gh-126624: Expose error code XML_ERROR_NOT_STARTED of Expat >=2.6.4 #126625

merged 3 commits into from
Jan 2, 2025

Conversation

hartwork
Copy link
Contributor
@hartwork hartwork commented Nov 9, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 9, 2024
Closed
@hartwork hartwork mentioned this pull request Nov 9, 2024
Closed
27 tasks
@hartwork hartwork force-pushed the issue-126624-expose-new-expat-2-6-4-error-code branch from 346217e to 090f254 Compare November 9, 2024 20:34
@ZeroIntensity
Copy link
Member

For the future, you don't need to force push anything--we squash merge at the end.

ZeroIntensity
ZeroIntensity approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member
@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @picnixz @Eclips4

hartwork and others added 2 commits November 9, 2024 23:00
@hartwork @picnixz
Apply suggestions from code review
5e67945 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@hartwork
Doc/library/pyexpat.rst: Fix trailing-whitespace
c83ba85
Eclips4
Eclips4 approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member
@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@hartwork
Copy link
Contributor Author

Ready to merge?

@ZeroIntensity
Copy link
Member
ZeroIntensity commented Nov 24, 2024 •
edited
Loading

I think so, but Kirill might want a second core dev approval.

@Eclips4 Eclips4 merged commit 8e48a6e into python:main Jan 2, 2025
43 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hartwork @picnixz @srinivasreddy
pythongh-126624: Expose error code XML_ERROR_NOT_STARTED of Expat…
496336b 
… >=2.6.4 (python#126625)

Expose error code ``XML_ERROR_NOT_STARTED`` in `xml.parsers.expat.errors` which was
introduced in Expat 2.6.4.


Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@picnixz picnixz picnixz approved these changes

@ruidazeng ruidazeng ruidazeng approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees
No one assigned
Labels
topic-XML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hartwork @ZeroIntensity @serhiy-storchaka @picnixz @ruidazeng @Eclips4
0