8000 bpo-36085: Add installer check for KB2533625 by zooba · Pull Request #12636 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

bpo-36085: Add installer check for KB2533625 #12636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2019

Conversation

zooba
Copy link
Member
@zooba zooba commented Mar 30, 2019

bpo-36085: Add installer check for KB2533625
Change default build option for Tools/msi/build.bat
Remove invalid reference to missing pdb file

https://bugs.python.org/issue36085

Change default build option for Tools/msi/build.bat
Remove invalid reference to missing pdb file
@eryksun
Copy link
Contributor
eryksun commented Mar 30, 2019

The note for the embeddable package should mention the required loader update. And should the CRT (3.5+) and loader updates (3.8+) also be noted for the nuget package?

@zooba
Copy link
Member Author
zooba commented Mar 30, 2019

I don't think it's necessary. I've never heard any complaints about the nuget package not having a CRT there already (and I have heard other complaints, so people know how to find me), and the KB requirement is for all of CPython and not something that we've ever tried to install automatically (unlike the CRT).

That said, I can't help but feel there's another doc page somewhere that should list the update. Or perhaps just the download page...

@zooba
Copy link
Member Author
zooba commented Mar 30, 2019

python-3.8.0.6662-amd64.zip

If anyone can help test on Win7 or Windows Server 2008 R2, here's a build of the installer. It should block right at the start, or else go to the usual "Install now/Advanced" screen. You won't be able to fully install it, as it doesn't have all the packages. If you do test, please attach the main log file from %TEMP% in the bpo issue.

@zooba
Copy link
Member Author
zooba commented Mar 31, 2019

python-3.8.0.6662.zip

Here's a 32-bit build

@db3l
Copy link
Contributor
db3l commented Mar 31, 2019

Here's a copy of an install log from a WIn7 SP1 (sans KB2533625) system that blocks.

Python 3.8.0dev6662 (32-bit)_20190330232436.log

@zooba zooba merged commit 79da388 into python:master Mar 31, 2019
@zooba zooba deleted the bpo-36085-installer branch March 31, 2019 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0