gh-126240: handle NULL returned by _Py_asdl_expr_seq_new
#126241
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
Oct 31, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2024
…ythonGH-126241) check return value of `_Py_asdl_expr_seq_new` (cherry picked from commit 94639f6) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
Sorry, @picnixz and @sobolevn, I could not cleanly backport this to |
|
GH-126243 is a backport of this pull request to the 3.13 branch. |
|
I'll take of the backport unless someone else wants to do it (just working on something else for a few minutes before coming back) |
|
@picnixz can you please do a manual backport to 3.12? |
|
Sure! |
|
GH-126245 is a backport of this pull request to the 3.12 branch. |
sobolevn
pushed a commit
that referenced
this pull request
Oct 31, 2024
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…ython#126241) check return value of `_Py_asdl_expr_seq_new`
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…ython#126241) check return value of `_Py_asdl_expr_seq_new`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've checked other constructors
_Py_asdl_*_seq_newbut couldn't find occurrences of them not having someif (!res)check after the call. I don't think this warrants a NEWS entry so I'll add theskip newslabel for now.