8000 gh-125729: Makes the presence of the :mod:`turtle` module dependent on the Tcl/Tk installer option. by CoderTCY · Pull Request #126176 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-125729: Makes the presence of the :mod:turtle module dependent on the Tcl/Tk installer option. #126176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 19, 2024
Merged

gh-125729: Makes the presence of the :mod:turtle module dependent on the Tcl/Tk installer option. #126176

merged 10 commits into from
Nov 19, 2024

Conversation

CoderTCY
Copy link
Contributor
@CoderTCY CoderTCY commented Oct 30, 2024 •
edited
Loading

@CoderTCY CoderTCY requested a review from a team as a code owner October 30, 2024 09:51
@ghost
Copy link
ghost commented Oct 30, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link
bedevere-app bot commented Oct 30, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@CoderTCY CoderTCY changed the title gh-126075: Add turtle.py into tcl/tk installation option gh-126076: Add turtle.py into tcl/tk installation option Oct 30, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 30, 2024
Closed
Wulian233
Wulian233 reviewed Oct 30, 2024
View reviewed changes
@Wulian233
Copy link
Contributor

This is a user-visible change, please add a news entry

@CoderTCY
Copy link
Contributor Author
CoderTCY commented Oct 30, 2024 •
edited
Loading

This is a user-visible change, please add a news entry

I tried, the server was 500

@CoderTCY @Wulian233
Update Tools/msi/bundle/Default.wxl
8000
cd54796 
Capitalize Tcl and Tk

Co-authored-by: Wulian <1055917385@qq.com>
@bedevere-app
Copy link
bedevere-app bot commented Oct 30, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link
bedevere-app bot commented Oct 30, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@picnixz picnixz changed the title gh-126076: Add turtle.py into tcl/tk installation option gh-125729: Add turtle.py into tcl/tk installation option Oct 30, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 30, 2024
Closed
picnixz
picnixz previously requested changes Oct 30, 2024
View reviewed changes
Copy link
Member
@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

As Wulian said, we still need a NEWS entry. You can write one manually using the blurb package (which you can install via pip install blurb)

@zooba
Copy link
Member
zooba commented Oct 30, 2024

Or if you're on Windows, run PCbuild/blurb.bat and it'll install/launch it for you.

zooba
zooba reviewed Oct 30, 2024
View reviewed changes
@CoderTCY
Copy link
Contributor Author
CoderTCY commented Oct 31, 2024 •
edited
Loading

As Wulian said, we still need a NEWS entry. You can write one manually using the blurb package (which you can install via pip install blurb)

Done.

zooba
zooba reviewed Oct 31, 2024
View reviewed changes
@CoderTCY CoderTCY changed the title gh-125729: Add turtle.py into tcl/tk installation option gh-126176: Add turtle.py into tcl/tk installation option Nov 1, 2024
@CoderTCY CoderTCY changed the title gh-126176: Add turtle.py into tcl/tk installation option gh-125729: Add turtle.py into tcl/tk installation option Nov 1, 2024
@CoderTCY CoderTCY requested a review from picnixz November 4, 2024 05:50
@CoderTCY @danielhollas
Update Misc/NEWS.d/next/Windows/2024-10-31-09-46-53.gh-issue-125729.K…
d7da6b8 
…dKVLa.rst

Co-authored-by: Daniel Hollas <danekhollas@gmail.com>
@CoderTCY @picnixz
Update Misc/NEWS.d/next/Windows/2024-10-31-09-46-53.gh-issue-125729.K…
ddb386a 
…dKVLa.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@CoderTCY CoderTCY requested a review from picnixz November 13, 2024 09:38
@CoderTCY CoderTCY changed the title gh-125729: Add turtle.py into tcl/tk installation option gh-125729: Makes the presence of the :mod:turtle module dependent on the Tcl/Tk installer option. Nov 16, 2024
@zooba zooba dismissed picnixz’s stale review November 19, 2024 17:18

NEWS entry has been provided

@zooba zooba merged commit 88dc84b into python:main Nov 19, 2024
38 checks passed
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@CoderTCY @ebonnal
pythongh-125729: Makes the installation of the turtle module dependen…
b9d2091 
…t on the Tcl/Tk install option (pythonGH-126176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba left review comments

@danielhollas danielhollas danielhollas left review comments

@Wulian233 Wulian233 Wulian233 approved these changes

@picnixz picnixz Awaiting requested review from picnixz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CoderTCY @Wulian233 @zooba @danielhollas @picnixz
0