8000 Android: update tests for newly-available functions affected by SELinux by mhsmith · Pull Request #126015 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

10000 Android: update tests for newly-available functions affected by SELinux #126015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

mhsmith
Copy link
Member
@mhsmith mhsmith commented Oct 26, 2024

#125946 increased the minimum Android API level to 24. This has caused some additional libc APIs to become available at compile time, which always return PermissionError at runtime.

I considered editing the configure script so that these functions are ignored at compile time, but experience from Chaquopy has shown that there's a lot of code out there which can handle a PermissionError (or its superclass OSError) when a function fails, but not the AttributeError which would happen if the function didn't exist at all. So I've skipped the affected tests instead.

@mhsmith
Copy link
Member Author
mhsmith commented Oct 26, 2024

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 3d3147c 🤖

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@mhsmith mhsmith requested a review from freakboy3742 October 26, 2024 19:23
Copy link
Contributor
@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good, and the logic around skipping the tests rather than reconfiguring makes sense to me.

@freakboy3742 freakboy3742 merged commit c51b560 into python:main Oct 27, 2024
40 checks passed
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…ux (python#126015)

Skip tests on Android that involve use of SELinux-protected methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0