8000 gh-125783: Add tests to prevent regressions with the combination of `ctypes` and metaclasses. by junkmd · Pull Request #125881 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-125783: Add tests to prevent regressions with the combination of ctypes and metaclasses. #125881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 25, 2024
Merged

gh-125783: Add tests to prevent regressions with the combination of ctypes and metaclasses. #125881

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80deddb
Add a test.
junkmd Oct 24, 2024
cf81f03
Add a test.
junkmd Oct 24, 2024
6903277
Remove the `_` prefix from local names.
junkmd Oct 24, 2024
47ec482
Apply suggestions from code review
junkmd Oct 25, 2024
4f1b74c
Update comments.
junkmd Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
  • Loading branch information
@junkmd @encukou
junkmd and encukou authored Oct 25, 2024
commit 47ec482cd96c8c8f1c0c4596eb16055568ec58d4
18 changes: 14 additions & 4 deletions Lib/test/test_ctypes/test_c_simple_type_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,26 @@ def tearDown(self):
# to not leak references, we must clean _pointer_type_cache
ctypes._reset_cache()

def test_early_return_in_dunder_new_1(self):
# Such an implementation is used in `IUnknown` of `comtypes`.
def test_creating_pointer_in_dunder_new_1(self):
# Test metaclass whose instances are C types; when the type is
# created it automatically creates a pointer type for itself.
# The pointer type is also an instance of the metaclass.
# Such an implementation is used in `IUnknown` of the `comtypes`
# project. See gh-124520.

class ct_meta(type):
def __new__(cls, name, bases, namespace):
self = super().__new__(cls, name, bases, namespace)

# Avoid recursion: don't set up a pointer to
# a pointer (to a pointer...)
if bases == (c_void_p,):
# When creating PtrBase itself, the name
# is not yet available
return self
if issubclass(self, PtrBase):
return self

if bases == (object,):
ptr_bases = (self, PtrBase)
else:
Expand Down Expand Up @@ -48,8 +58,8 @@ class Sub2(Sub):
self.assertTrue(issubclass(POINTER(Sub2), POINTER(Sub)))
self.assertTrue(issubclass(POINTER(Sub), POINTER(CtBase)))

def test_early_return_in_dunder_new_2(self):
# Such an implementation is used in `CoClass` of `comtypes`.
def test_creating_pointer_in_dunder_new_2(self):
# A simpler variant of the above, used in `CoClass` of `comtypes`.

class ct_meta(type):
def __new__(cls, name, bases, namespace):
Expand Down
Loading
0