8000 [3.9] [3.10] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) (GH-125255) by miss-islington · Pull Request #125835 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.9] [3.10] gh-107902: gh-108948: Don't test 8000 setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) (GH-125255) #125835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.9] [3.10] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) (GH-125255) #125835

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.

(cherry picked from commit 6bbaab8)

Co-authored-by: Petr Viktorin encukou@gmail.com
Co-authored-by: Victor Stinner vstinner@python.org

@encukou @vstinner @miss-islington
[3.10] pythongh-107902: pythongh-108948: Don't test setting suid/sgid…
3c00a44 
…/sticky on systems that don't support them (pythonGH-108368) (pythonGH-109697) (pythonGH-125255)

* pythongh-107902: Don't test setting suid/sgid on systems that don't support them (pythonGH-108368)

* pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pythonGH-109697)

On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.

---------

(cherry picked from commit 6bbaab8)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Oct 22, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 22, 2024
Closed
2 tasks
@bedevere-app bedevere-app bot mentioned this pull request Oct 22, 2024
Merged
@encukou
Copy link
Member
encukou commented Oct 22, 2024

Thanks @miss-islington, but let's use #125576 instead!

@encukou encukou closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees
No one assigned
Labels
awaiting review skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miss-islington @encukou
0