8000 gh-125660: Python implementation of `json.loads()` accepts invalid unicode escapes by nineteendo · Pull Request #125683 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-125660: Python implementation of json.loads() accepts invalid unicode escapes #125683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 18, 2024
Merged

gh-125660: Python implementation of json.loads() accepts invalid unicode escapes #125683

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a40d522
Reject invalid unicode escapes
nineteendo Oct 18, 2024
8587c66
Add tests
nineteendo Oct 18, 2024
8819807
Wrong variable
nineteendo Oct 18, 2024
f5c2be5
Remove walrus operator
nineteendo Oct 18, 2024
fbebc0c
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 18, 2024
aa33587
Fix start and variable
nineteendo Oct 18, 2024
be74e21
Rename 2024-10-18-08-58-10.gh-issue-125660.sDdDqO.rst to 2024-10-18-0…
nineteendo Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Reject invalid unicode escapes
  • Loading branch information
@nineteendo
nineteendo authored Oct 18, 2024
commit a40d52201639c82ec3f15e8795f8c83897deb9b5
8 changes: 4 additions & 4 deletions Lib/json/decoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,17 @@ def __reduce__(self):
}


HEXDIGITS = re.compile(r'[0-9A-Fa-f]{4}', FLAGS)
STRINGCHUNK = re.compile(r'(.*?)(["\\\x00-\x1f])', FLAGS)
BACKSLASH = {
'"': '"', '\\': '\\', '/': '/',
'b': '\b', 'f': '\f', 'n': '\n', 'r': '\r', 't': '\t',
}

def _decode_uXXXX(s, pos):
esc = s[pos + 1:pos + 5]
if len(esc) == 4 and esc[1] not in 'xX':
def _decode_uXXXX(s, pos, _m=HEXDIGITS.match):
if match := _m(s, end):
try:
return int(esc, 16)
return int(match.group(), 16)
except ValueError:
pass
msg = "Invalid \\uXXXX escape"
Expand Down
Loading
0