gh-100141: Allow pdb to deal with empty file #125425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rruuaanng
reviewed
Oct 14, 2024
Lib/test/test_pdb.py
Outdated
Comment on lines
3955
to
3956
| _, _ = self.run_pdb_script(script, commands) | ||
| _, _ = self.run_pdb_module(script, commands) |
There was a problem hiding this comment.
Suggested change
| _, _ = self.run_pdb_script(script, commands) | |
| _, _ = self.run_pdb_module(script, commands) | |
| self.run_pdb_script(script, commands) | |
| self.run_pdb_module(script, commands) |
There was a problem hiding this comment.
I thought about this again and I think we should at least check for something so I changed the test a bit.
rruuaanng
approved these changes
Oct 14, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
iritkatriel
reviewed
Oct 15, 2024
iritkatriel
approved these changes
Oct 15, 2024
|
Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 15, 2024
(cherry picked from commit bb9604b) Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 15, 2024
(cherry picked from commit bb9604b) Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
|
GH-125536 is a backport of this pull request to the 3.13 branch. |
|
GH-125537 is a backport of this pull request to the 3.12 branch. |
|
Shoot, I forgot to add the co-author in the commit... |
This was referenced Oct 15, 2024
gaogaotiantian
added a commit
that referenced
this pull request
Oct 15, 2024
gaogaotiantian
added a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f_lineno == 0is possible and pdb should just stop. The original fix is from #106467, I added the regression test.Co-authored-by: SonOfLilit