8000 Prefer "similar" over "equivalent" in tutorial by sirosen · Pull Request #125343 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

Prefer "similar" over "equivalent" in tutorial #125343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

sirosen
Copy link
Contributor
@sirosen sirosen commented Oct 12, 2024

In the datastructures tutorial doc, some operations are described as "equivalent to" others.
This has led to some user-confusion -- at least here in the Discourse forums -- about cases in which the operations differ.

This change doesn't systematically eliminate the word "equivalent" from the tutorial.
It just substitutes "similar to" in several cases in which "equivalent to" could mislead users into expecting exact equivalence.


Some thread participants in Discourse seem to want more changes to this doc.
I'm not against further changes, but in my view this change of wording is trivial and can be made as a first step.


📚 Documentation preview 📚: https://cpython-previews--125343.org.readthedocs.build/

In the datastructures tutorial doc, some operations are described as
"equivalent to" others. This has led to some user-confusion -- at
least in the Discourse forums -- about cases in which the operations
differ.

This change doesn't systematically eliminate the word "equivalent"
from the tutorial. It just substitutes "similar to" in several cases
in which "equivalent to" could mislead users into expecting exact
equivalence.
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 12, 2024
@nineteendo
Copy link
Contributor

Maybe roughly equivalent is better?

@nedbat nedbat added skip issue needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 12, 2024
@@ -93,7 +93,7 @@ objects:
.. method:: list.copy()
:noindex:

Return a shallow copy of the list. Equivalent to ``a[:]``.
Return a shallow copy of the list. Similar to ``a[:]``.
Copy link
Member
@picnixz picnixz Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, this one is really equivalent but maybe I'm wrong. And many scripts use a[:] instead of .copy(). 8000

@@ -56,7 +56,7 @@ objects:
.. method:: list.clear()
:noindex:

Remove all items from the list. Equivalent to ``del a[:]``.
Remove all items from the list. Similar to ``del a[:]``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@nedbat nedbat merged commit 4a2282b into python:main Oct 12, 2024
30 checks passed
@miss-islington-app
Copy link

Thanks @sirosen for the PR, and @nedbat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2024
In the datastructures tutorial doc, some operations are described as
"equivalent to" others. This has led to some user-confusion -- at
least in the Discourse forums -- about cases in which the operations
differ.

This change doesn't systematically eliminate the word "equivalent"
from the tutorial. It just substitutes "similar to" in several cases
in which "equivalent to" could mislead users into expecting exact
equivalence.
(cherry picked from commit 4a2282b)

Co-authored-by: Stephen Rosen <sirosen@globus.org>
@bedevere-app
Copy link
bedevere-app bot commented Oct 12, 2024

GH-125372 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2024
In the datastructures tutorial doc, some operations are described as
"equivalent to" others. This has led to some user-confusion -- at
least in the Discourse forums -- about cases in which the operations
differ.

This change doesn't systematically eliminate the word "equivalent"
from the tutorial. It just substitutes "similar to" in several cases
in which "equivalent to" could mislead users into expecting exact
equivalence.
(cherry picked from commit 4a2282b)

Co-authored-by: Stephen Rosen <sirosen@globus.org>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 12, 2024
@bedevere-app
Copy link
bedevere-app bot commented Oct 12, 2024

GH-125373 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 12, 2024
@sirosen sirosen deleted the equivalence-is-similar-to-similarity branch October 13, 2024 00:11
willingc pushed a commit that referenced this pull request Oct 30, 2024
…-125372)

Prefer "similar" over "equivalent" in tutorial (GH-125343)

In the datastructures tutorial doc, some operations are described as
"equivalent to" others. This has led to some user-confusion -- at
least in the Discourse forums -- about cases in which the operations
differ.

This change doesn't systematically eliminate the word "equivalent"
from the tutorial. It just substitutes "similar to" in several cases
in which "equivalent to" could mislead users into expecting exact
equivalence.
(cherry picked from commit 4a2282b)

Co-authored-by: Stephen Rosen <sirosen@globus.org>
willingc pushed a commit that referenced this pull request Oct 30, 2024
…-125373)

Prefer "similar" over "equivalent" in tutorial (GH-125343)

In the datastructures tutorial doc, some operations are described as
"equivalent to" others. This has led to some user-confusion -- at
least in the Discourse forums -- about cases in which the operations
differ.

This change doesn't systematically eliminate the word "equivalent"
from the tutorial. It just substitutes "similar to" in several cases
in which "equivalent to" could mislead users into expecting exact
equivalence.
(cherry picked from commit 4a2282b)

Co-authored-by: Stephen Rosen <sirosen@globus.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0