8000 Doc: Use the Snowball project's PyStemmer library by AA-Turner · Pull Request #125264 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Doc: Use the Snowball project's PyStemmer library #125264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Doc: Use the Snowball project's PyStemmer library #125264

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c849c8
Doc: Use the Snowball project's PyStemmer library
AA-Turner Oct 10, 2024
c9d685c
Don't use PyStemmer with doctest
AA-Turner Oct 10, 2024
551edb0
try --only-binary
AA-Turner Oct 10, 2024
f1b1dc7
Revert "try --only-binary"
AA-Turner Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "try --only-binary" 
This reverts commit 551edb0.
  • Loading branch information
@AA-Turner
AA-Turner committed Oct 10, 2024
commit f1b1dc752be26bbec75d6fd02885802eaee719ee
2 changes: 2 additions & 0 deletions .github/workflows/reusable-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ jobs:
run: ./configure --with-pydebug
- name: 'Build CPython'
run: make -j4
- name: 'Remove PyStemmer from requirements.txt'
run: sed -i '/PyStemmer.*/d' Doc/requirements.txt
- name: 'Install build dependencies'
run: make -C Doc/ PYTHON=../python venv
# Use "xvfb-run" since some doctest tests open GUI windows
Expand Down
4 changes: 2 additions & 2 deletions Doc/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,11 @@ venv:
echo "Creating venv in $(VENVDIR)"; \
if $(UV) --version >/dev/null 2>&1; then \
$(UV) venv $(VENVDIR); \
VIRTUAL_ENV=$(VENVDIR) $(UV) pip install -r $(REQUIREMENTS) --only-binary PyStemmer; \
VIRTUAL_ENV=$(VENVDIR) $(UV) pip install -r $(REQUIREMENTS); \
else \
$(PYTHON) -m venv $(VENVDIR); \
$(VENVDIR)/bin/python3 -m pip install --upgrade pip; \
$(VENVDIR)/bin/python3 -m pip install -r $(REQUIREMENTS) --only-binary PyStemmer; \
$(VENVDIR)/bin/python3 -m pip install -r $(REQUIREMENTS); \
fi; \
echo "The venv has been created in the $(VENVDIR) directory"; \
fi
Expand Down
Loading
0