8000 bpo-36406: Handle namespace packages in doctest by tirkarthi · Pull Request #12520 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-36406: Handle namespace packages in doctest #12520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2019
Merged

bpo-36406: Handle namespace packages in doctest #12520

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
476deba
Handle empty packages in doctest
tirkarthi Mar 24, 2019
4165f9f
Use module.__name__ when filename is None and refactor tests
tirkarthi Mar 26, 2019
89a9de8
Refactor None check
tirkarthi Apr 8, 2019
d6bf090
Use period at end of comment.
tirkarthi May 30, 2019
f0ef6f2
Change empty to namespace.
tirkarthi Sep 11, 2019
File filter

Filter by extension

Filter by extension
8000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/doctest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,9 @@ def _get_test(self, obj, name, module, globs, source_lines):
if module is None:
filename = None
else:
filename = getattr(module, '__file__', module.__name__)
# __file__ can be None for empty packages
filename = (getattr(module, '__file__', module.__name__) or
module.__name__)
if filename[-4:] == ".pyc":
filename = filename[:-1]
return self._parser.get_doctest(docstring, globs, name,
Expand Down
6 changes: 5 additions & 1 deletion Lib/test/test_doctest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,8 +698,12 @@ def test_empty_namespace_package(self):
finally:
support.forget(pkg_name)
sys.path.pop()
assert doctest.DocTestFinder().find(mod) == []

include_empty_finder = doctest.DocTestFinder(exclude_empty=False)
exclude_empty_finder = doctest.DocTestFinder(exclude_empty=True)

self.assertEqual(len(include_empty_finder.find(mod)), 1)
self.assertEqual(len(exclude_empty_finder.find(mod)), 0)

def test_DocTestParser(): r"""
Unit tests for the `DocTestParser` class.
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2019-03-24-12-12-27.bpo-36406.mCEkOl.rst < 67E9 span data-view-component="true">
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Handle empty packages in :mod:`doctest`. Patch by Karthikeyan Singaravelan.
0