8000 gh-124969: Skip the test for ALT_DIGITS also on iOS by serhiy-storchaka · Pull Request #125177 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-124969: Skip the test for ALT_DIGITS also on iOS #125177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

gh-124969: Skip the test for ALT_DIGITS also on iOS #125177

merged 1 commit into from
Oct 9, 2024

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Oct 9, 2024 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Oct 9, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 9, 2024
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 9, 2024
Merged
@mhsmith
Copy link
Member
mhsmith commented Oct 9, 2024

!buildbot ios

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 716c060 🤖

The command will test the builders whose names match following regular expression: ios

The builders matched are:

  • iOS ARM64 Simulator PR

freakboy3742
freakboy3742 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor
@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can make out, skipping this test on iOS is as good as we're going to get.

The macOS and iOS langinfo.h headers both define ALT_DIGITS; but experimentally, any request to retrieve the alt digits returns an empty string. The fa_IR subtest is passing because that locale isn't defined, so it's falling back to the previously set locale (en_US). The jp_JP locale does exist, and some locale values (e.g. ABDAY_1) are defined; but ALT_DIGITS values clearly aren't.

I can't find any documentation about this beyond the man page for nl_langinfo, which doesn't shed any light on ALT_DIGITS specifically.

@freakboy3742 freakboy3742 merged commit 9ad55e8 into python:main Oct 9, 2024
38 checks passed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @mhsmith @bedevere-bot @freakboy3742
0