8000 [3.9] gh-89452: GHA: Set --with-dbmliborder to avoid issues with homebrew's gdbm 1.24 (GH-125112) by encukou · Pull Request #125176 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.9] gh-89452: GHA: Set --with-dbmliborder to avoid issues with homebrew's gdbm 1.24 (GH-125112) #125176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[3.9] gh-89452: GHA: Set --with-dbmliborder to avoid issues with homebrew's gdbm 1.24 (GH-125112) #125176

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
993f70d
[3.9] gh-89452: GHA: Set --with-dbmliborder to avoid issues with home…
encukou Oct 8, 2024
fda2782
Merge branch '3.9' into backport-850189a-3.9
ambv Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[3.9] gh-89452: GHA: Set --with-dbmliborder to avoid issues with home… 
…brew's gdbm 1.24 (GH-125112)

Per https://github.com/python/cpython/issues/89452GH-issuecomment-1116329316,
the issue is fixed in configure for 3.11+, and

> For older Python versions, the workaround is to build with:
>
>     ./configure --with-dbmliborder=gdbm:ndbm

We need this workaround in GitHub Actions, otherwise the tests fail.
(cherry picked from commit 850189a)
  • Loading branch information
@encukou
encukou committed Oct 9, 2024
commit 993f70dba1c0c5728e048d93c86bcfd30ba53234
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,9 @@ jobs:
--with-pydebug \
--with-openssl="$(brew --prefix openssl@3.0)" \
--with-tcltk-libs="$(pkg-config --libs tk)" \
--with-tcltk-includes="$(pkg-config --cflags tk)"
--with-tcltk-includes="$(pkg-config --cflags tk)" \
--with-dbmliborder=gdbm:ndbm
# (--with-dbmliborder needed for homebrew's gdbm 1.24: see gh-89452)
- name: Build CPython
run: make -j4
- name: Display build info
Expand Down
Loading
0