-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-125022: add support for simple SIMD features detection #125011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b4de356
to
c33fb91
Compare
c33fb91
to
3c0b4f1
Compare
🤖 New build scheduled with the buildbot fleet by @picnixz for commit d6213a5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F125011%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Huh, so there's an illegal instruction for AMD64/FreeBSD14. I'll need to investigate. |
!buildbot AMD64 FreeBSD14 PR |
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 79d5b34 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F125011%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot AMD64 FreeBSD14 PR |
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 88df3b7 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F125011%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot AMD64 FreeBSD14 PR |
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 04012b4 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F125011%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Urgh, so |
In #124951, there has been some initial discussion on improving the performances of base64 and possibly
{bytearray,bytes,str}.translate
using SIMD instructions.More generally, if we want to use specific SIMD instructions, it'd be good if we at least know whether we can use them or not. This PR is a PoC, experimental and (hence the skip news).
Note that the detection is essentially based on what was done in the blake2 module (though the flags being detected are different in this case but we can always add all those that are needed). To prepare for a harder detection of AVX instructions support, I added all the flags that are known to CPUID and possibly relevant. Note that more work needs to be done for a production use, especially in autoconf I think.
Note
The detection of a wider large family of CPUs (here we just assume Intel for simplicity and because we don't want to be overcomplicated for now) is still an ongoing work.
cc @gpshead