10000 gh-124653: relax (again) detection of queue API for logging handlers by picnixz · Pull Request #124897 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-124653: relax (again) detection of queue API for logging handlers #124897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 7, 2024
Merged

gh-124653: relax (again) detection of queue API for logging handlers #124897

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d93b5f4
Relax constraints on the Queue API checks for logging.
picnixz Oct 2, 2024
43872bc
update docs
picnixz Oct 2, 2024
52a456a
blurb
picnixz Oct 2, 2024
fe6c25d
fix test
picnixz Oct 2, 2024
985d3c3
fortify tests
picnixz Oct 2, 2024
87379b1
update comments
picnixz Oct 2, 2024
c1d1f16
fix WASI tests
picnixz Oct 2, 2024
e2323ee
Update Lib/test/test_logging.py
picnixz Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comments
  • Loading branch information
@picnixz
picnixz committed Oct 2, 2024
commit 87379b1915009826a4b97cf5eb890a72b8a40b88
4 changes: 2 additions & 2 deletions Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3973,8 +3973,8 @@ def test_config_queue_handler_does_not_create_multiprocessing_manager(self, mana
CustomQueueFakeProtocol(),
MinimalQueueProtocol(),
# multiprocessing.Queue() is a valid queue for the logging module
# multiprocessing.SimpleQueue() is NOT valid because it lacks the
# 'put_nowait' method which is needed by the logging queue handler.
# but multiprocessing.SimpleQueue() is NOT valid because it lacks
# the 'put_nowait' method needed by the logging queue handler.
multiprocessing.Queue(),
]:
with self.subTest(qspec=qspec):
Expand Down
Loading
0