8000 GH-124715: trashcan protection for all GC objects by nascheme · Pull Request #124716 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-124715: trashcan protection for all GC objects #124716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

GH-124715: trashcan protection for all GC objects #124716

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2173832
wip: add trashcan protection to all GC objects
nascheme Sep 27, 2024
73644a7
wip: fix _PyObject_GC_UNTRACK calls
nascheme Sep 27, 2024
64a26ee
wip: add and use _PyObject_GC_TRACK_SAFE
nascheme Sep 27, 2024
dd4db33
wip: remove _PyObject_GC_TRACK_SAFE
nascheme Sep 27, 2024
31b2ede
Add blurb.
nascheme Sep 27, 2024
8443e84
Call _Py_Dealloc from ceval.c.
nascheme Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Call _Py_Dealloc from ceval.c. 
Calling tp_dealloc directly will bypass the trashcan protection and will
not preserve the requirement that GC objects are untracked before
tp_dealloc is called.
  • Loading branch information
@nascheme
nascheme committed Oct 1, 2024
commit 8443e847c9ca6ee30b5392a91c9114cfd0a4f5b5
3 changes: 1 addition & 2 deletions Python/ceval.c
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@
} \
_Py_DECREF_STAT_INC(); \
if (--op->ob_refcnt == 0) { \
destructor dealloc = Py_TYPE(op)->tp_dealloc; \
(*dealloc)(op); \
_Py_Dealloc(op); \
} \
} while (0)

Expand Down
0