8000 [3.12] gh-124487: Update Windows API version to Windows 8.1 by zooba · Pull Request #124676 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.12] gh-124487: Update Windows API version to Windows 8.1 #124676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2024
Merged

[3.12] gh-124487: Update Windows API version to Windows 8.1 #124676

merged 1 commit into from
Sep 27, 2024

Conversation

zooba
Copy link
Member
@zooba zooba commented Sep 27, 2024 •
edited by bedevere-app bot
Loading

@zooba zooba requested a review from a team as a code owner September 27, 2024 14:59
@bedevere-app bedevere-app bot mentioned this pull request Sep 27, 2024
Closed
@zooba zooba mentioned this pull request Sep 27, 2024
Merged
@Yhg1s Yhg1s merged commit a4916e6 into python:3.12 Sep 27, 2024
29 checks passed
@zooba zooba added the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
@miss-islington-app
Copy link

Thanks @zooba for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@zooba @miss-islington
[3.12] pythongh-124487: Update Windows API version to Windows 8.1 (py…
28c8549 
…thonGH-124676)

(cherry picked from commit a4916e6)

Co-authored-by: Steve Dower <steve.dower@python.org>
pythongh-124487: Update Windows API version to Windows 8.1
@bedevere-app
Copy link
bedevere-app bot commented Sep 27, 2024

GH-124702 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
@zooba zooba deleted the gh-124487-3.12 branch September 27, 2024 19:07
@bedevere-app
Copy link
bedevere-app bot commented Sep 27, 2024

GH-124702 is a backport of this pull request to the 3.13 branch.

Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @zooba
[3.13] gh-124487: Update Windows API version to Windows 8.1 (GH-124676)…
09aecb6 
… (#124702)

gh-124487: Update Windows API version to Windows 8.1 (GH-124676)
(cherry picked from commit a4916e6)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.13 has failed when building commit 09aecb6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1590/builds/22) and take a look at the build logs.
  4. Check if the failure is related to this commit (09aecb6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1590/builds/22

Failed tests:

  • test_android

Failed subtests:

  • test_rate_limit - test.test_android.TestAndroidOutput.test_rate_limit

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.13/test/test_android.py", line 424, in test_rate_limit
    self.assertAlmostEqual(
    ~~~~~~~~~~~~~~~~~~~~~~^
        write_bucketful(), MAX_KB_PER_SECOND,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        delta=MAX_KB_PER_SECOND * 0.1
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 88.82680452107101 != 100 within 10.0 delta (11.173195478928989 difference)


Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.13/test/test_android.py", line 424, in test_rate_limit
    self.assertAlmostEqual(
    ~~~~~~~~~~~~~~~~~~~~~~^
        write_bucketful(), MAX_KB_PER_SECOND,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        delta=MAX_KB_PER_SECOND * 0.1
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 111.25592844486414 != 100 within 10.0 delta (11.25592844486414 difference)

@mhsmith
Copy link
Member
mhsmith commented Sep 28, 2024

Unrelated buildbot failure – will be fixed by #124035.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @bedevere-bot @mhsmith @Yhg1s
0