8000 gh-124309: Modernize the `staggered_race` implementation to support eager task factories by ZeroIntensity · Pull Request #124390 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-124309: Modernize the staggered_race implementation to support eager task factories #124390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 26, 2024
Merged

gh-124309: Modernize the staggered_race implementation to support eager task factories #124390

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4002695
Partial implementation.
ZeroIntensity Sep 23, 2024
302d7e3
Add unit tests.
ZeroIntensity Sep 23, 2024
e2cf78a
Fix tests with eager task factory.
ZeroIntensity Sep 23, 2024
48a1798
Add NEWS entry.
ZeroIntensity Sep 23, 2024
e213f51
Refactor to use only public APIs
ZeroIntensity Sep 24, 2024
0d27caf
Revert changes to TaskGroup.
ZeroIntensity Sep 24, 2024
229eaf8
Add extra test.
ZeroIntensity Sep 24, 2024
aa00ebc
Add sanity check.
ZeroIntensity Sep 24, 2024
57bb25a
Remove obsolete loop parameter.
ZeroIntensity Sep 24, 2024
6940889
Deprecate the loop parameter.
ZeroIntensity Sep 24, 2024
d01ed7f
News: only mention the bugfix.
ZeroIntensity Sep 24, 2024
9c04271
Update Lib/test/test_asyncio/test_staggered.py
ZeroIntensity Sep 26, 2024
e11a52a
Update Lib/asyncio/staggered.py
ZeroIntensity Sep 26, 2024
3fbbedb
code review
kumaraditya303 Sep 26, 2024
1b2e217
fix news
kumaraditya303 Sep 26, 2024
e1047b9
better tests
kumaraditya303 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code review
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Sep 26, 2024
commit 3fbbedb0ad64eeba7284d1244158b892497d55c8
11 changes: 1 addition & 10 deletions Lib/asyncio/staggered.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
class _Done(Exception):
pass

async def staggered_race(coro_fns, delay, *, loop=None):
async def staggered_race(coro_fns, delay):
"""Run coroutines with staggered start times and take the first to finish.

This method takes an iterable of coroutine functions. The first one is
Expand Down Expand Up @@ -65,15 +65,6 @@ async def staggered_race(coro_fns, delay, *, loop=None):
winner_index = None
exceptions = []

if loop is not None:
import warnings
warnings._deprecated(
'loop',
'the {name!r} parameter is deprecated and slated for removal in '
'Python {remove}; it is ignored since 3.14',
remove=(3, 16),
)

async def run_one_coro(this_index, coro_fn, this_failed):
try:
result = await coro_fn()
Expand Down
6 changes: 4 additions & 2 deletions Lib/test/test_asyncio/test_eager_task_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,11 @@ async def run():

self.run_coro(run())

# See GH-124309 for both of these
def test_staggered_race_with_eager_tasks(self):
# See https://github.com/python/cpython/issues/124309

async def fail():
await asyncio.sleep(0) # Dummy coroutine
await asyncio.sleep(0)
raise ValueError("no good")

async def run():
Expand All @@ -237,6 +238,7 @@ async def run():
self.run_coro(run())

def test_staggered_race_with_eager_tasks_no_delay(self):
# See https://github.com/python/cpython/issues/124309
async def fail():
raise ValueError("no good")

Expand Down
0