8000 gh-124344: Make `_PyObject_IS_GC()` use underscored `PyType_IS_GC()` by neonene · Pull Request #124349 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-124344: Make _PyObject_IS_GC() use underscored PyType_IS_GC() #124349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

gh-124344: Make _PyObject_IS_GC() use underscored PyType_IS_GC() #124349

merged 1 commit into from
Sep 23, 2024

Conversation

neonene
Copy link
Contributor
@neonene neonene commented Sep 23, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 23, 2024
Closed
@corona10 corona10 requested a review from vstinner September 23, 2024 18:50
corona10
corona10 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member
@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too

vstinner
vstinner approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit d9d5b3d into python:main Sep 23, 2024
39 checks passed
@vstinner
Copy link
Member

Merged, thanks @neonene.

@neonene neonene deleted the is_gc branch September 23, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
skip news
< 46A3 input type="hidden" data-csrf="true" name="authenticity_token" value="xNBAV06yw6qDKR/jwfQMAg/M6fgqFEcOYKE8wJF6vtRCDNQRGCTamPpHKyKBJp8EyV0mf9AmnYdAfny+NGiPtw==" />
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonene @vstinner @corona10
0