8000 [3.13] gh-123836: workaround fmod(x, y) bug on Windows (GH-124171) by skirpichev · Pull Request #124187 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.13] gh-123836: workaround fmod(x, y) bug on Windows (GH-124171) #124187

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2024
Merged

[3.13] gh-123836: workaround fmod(x, y) bug on Windows (GH-124171) #124187

merged 1 commit into from
Sep 30, 2024

Conversation

skirpichev
Copy link
Contributor
@skirpichev skirpichev commented Sep 17, 2024 •
edited by bedevere-app bot
Loading

Buildbot failure on Windows 10 with MSC v.1916 64 bit (AMD64):

FAIL: testFmod (test.test_math.MathTests.testFmod) ---------------------------------------------------------------------- Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_math.py", line 605, in testFmod
    self.ftest('fmod(-10, 1)', math.fmod(-10, 1), -0.0)
    ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_math.py", line 258, in ftest
    self.fail("{}: {}".format(name, failure))
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: fmod(-10, 1): expected -0.0, got 0.0 (zero has wrong sign)

Here Windows loose sign of the result; if y is nonzero, the result should have the same sign as x.

This amends commit 28aea5d.
(cherry picked from commit f4dd440)

@skirpichev
[3.13] pythongh-123836: workaround fmod(x, y) bug on Windows (pythonG…
e5f6a2b 
…H-124171)

Buildbot failure on Windows 10 with MSC v.1916 64 bit (AMD64):
FAIL: testFmod (test.test_math.MathTests.testFmod)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_math.py", line 605, in testFmod
    self.ftest('fmod(-10, 1)', math.fmod(-10, 1), -0.0)
    ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_math.py", line 258, in ftest
    self.fail("{}: {}".format(name, failure))
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: fmod(-10, 1): expected -0.0, got 0.0 (zero has wrong sign)

Here Windows loose sign of the result; if y is nonzero, the result
should have the same sign as x.

This amends commit 28aea5d.
(cherry picked from commit f4dd440)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
This was referenced Sep 17, 2024
Merged
Closed
vstinner
vstinner approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou encukou mentioned this pull request Sep 18, 2024
Merged
@Yhg1s Yhg1s merged commit 99185bd into python:3.13 Sep 30, 2024
39 checks passed
@skirpichev skirpichev deleted the backport-f4dd440-3.13 branch September 30, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skirpichev @vstinner @Yhg1s
0