-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-123290: curses: fix reference leaks in error-branches and cleanup module's initialization #123910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
gh-123290: curses: fix reference leaks in error-branches and cleanup module's initialization #123910
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3ce06f4
Fix reference leaks in the error-branches.
picnixz 81bcde8
protect macros expansions using `do { ... } while (0)` constructions
picnixz 848cc3e
use uppercase global flags
picnixz ea3fd8d
cosmetic changes
picnixz 557a53c
improve `SetDictInt` macro
picnixz a92fc1f
undef utililty macros
picnixz 9ce0289
improve macro usage
picnixz fd7372a
update globals
picnixz 384716d
address Victor's review
picnixz 24f47a1
fix compilation if `Py_GIL_DISABLED` is defined
picnixz 4a1003c
use a local macro
picnixz 356b00c
remove unused undefs
picnixz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
undef utililty macros
- Loading branch information
commit a92fc1fb8094356bdc4c49491cb9eb7c84b14e95
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that it's useful to undefine macros at the end of the file. It's ok to have macros defined for a whole C file.