8000 gh-123849: Fix DumpTests.test_table_dump() crash on SQLite when foreign keys are enabled by default. by felixxm · Pull Request #123859 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-123849: Fix DumpTests.test_table_dump() crash on SQLite when foreign keys are enabled by default. #123859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024
Merged

gh-123849: Fix DumpTests.test_table_dump() crash on SQLite when foreign keys are enabled by default. #123859

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9f9c58
gh-123849: Fix DumpTests.test_table_dump() crash on SQLite when forei…
felixxm Sep 9, 2024
7b67345
Merge branch 'main' into gh-123849
erlend-aasland Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-123849: Fix DumpTests.test_table_dump() crash on SQLite when forei… 
…gn keys are enabled by default.

Thanks Derothin for the report.

Test regression in de777e4.
  • Loading branch information
@felixxm
felixxm committed Sep 9, 2024
commit b9f9c58422ade8914eb21563d3b90e5e320dab15
3 changes: 2 additions & 1 deletion Lib/test/test_sqlite3/test_dump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class DumpTests(MemoryDatabaseMixin, unittest.TestCase):

def test_table_dump(self):
expected_sqls = [
"PRAGMA foreign_keys=OFF;",
"""CREATE TABLE "index"("index" blob);"""
,
"""INSERT INTO "index" VALUES(X'01');"""
Expand Down Expand Up @@ -48,7 +49,7 @@ def test_table_dump(self):
expected_sqls = [
"PRAGMA foreign_keys=OFF;",
"BEGIN TRANSACTION;",
*expected_sqls,
*expected_sqls[1:],
"COMMIT;",
]
[self.assertEqual(expected_sqls[i], actual_sqls[i])
Expand Down
Loading
0