8000 gh-123756: Only allow restart in command line mode by gaogaotiantian · Pull Request #123757 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-123756: Only allow restart in command line mode #123757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 25, 2024
Merged

gh-123756: Only allow restart in command line mode #123757

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8c6fb05
Only allow restart in command line mode
gaogaotiantian Sep 6, 2024
8a46e08
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 6, 2024
2342a34
Use an invocation type enum for restart check
gaogaotiantian Sep 7, 2024
1d731c7
Add PdbInvokeType to __all__
gaogaotiantian Sep 7, 2024
78746ba
Fix pyclbr test
gaogaotiantian Sep 7, 2024
2b9e225
Add unknown for invocation type
gaogaotiantian Sep 7, 2024
420e498
Change the enum name and update docs/tests
gaogaotiantian Sep 20, 2024
a49a13e
Update news
gaogaotiantian Sep 20, 2024
a4b995e
Fix test_pyclbr.py
gaogaotiantian Sep 20, 2024
03f91dc
Use simple strings for mode
gaogaotiantian Sep 24, 2024
8284118
Revert changes to test_pyclbr
gaogaotiantian Sep 24, 2024
162c53c
Update 2024-09-06-01-35-11.gh-issue-123756.Ozbhke.rst
gaogaotiantian Sep 24, 2024
f9d01f9
Update docs
gaogaotiantian Sep 24, 2024
0265d90
Update error messages
gaogaotiantian Sep 25, 2024
78e2e66
Merge branch 'main' into pdb-allow-restart
gaogaotiantian Sep 25, 2024
c50b039
Update docs
gaogaotiantian Sep 25, 2024
27f0656
Update test to match the error message
gaogaotiantian Sep 25, 2024
7281465
Add whatsnew entry to the change
gaogaotiantian Sep 25, 2024
3ce16ec
Remove trailing space
gaogaotiantian Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Only allow restart in command line mode
  • Loading branch information
@gaogaotiantian
gaogaotiantian committed Sep 6, 2024
commit 8c6fb0514346ba85aac4187ca0e682a559774b72
9 changes: 7 additions & 2 deletions Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ class Pdb(bdb.Bdb, cmd.Cmd):
_last_pdb_instance = None

def __init__(self, completekey='tab', stdin=None, stdout=None, skip=None,
nosigint=False, readrc=True):
nosigint=False, readrc=True, allow_restart=False):
bdb.Bdb.__init__(self, skip=skip)
cmd.Cmd.__init__(self, completekey, stdin, stdout)
sys.audit("pdb.Pdb")
Expand All @@ -321,6 +321,7 @@ def __init__(self, completekey='tab', stdin=None, stdout=None, skip=None,
self.mainpyfile = ''
self._wait_for_mainpyfile = False
self.tb_lineno = {}
self.allow_restart = allow_restart
# Try to load readline if it exists
try:
import readline
Expand Down Expand Up @@ -1607,6 +1608,10 @@ def do_run(self, arg):
sys.argv. History, breakpoints, actions and debugger options
are preserved. "restart" is an alias for "run".
"""
if not self.allow_restart:
self.error('run/restart command is only allowed in command line usage:\n'
'e.g. "python -m pdb myscript.py"')
return
if arg:
import shlex
argv0 = sys.argv[0:1]
Expand Down Expand Up @@ -2476,7 +2481,7 @@ def main():
# modified by the script being debugged. It's a bad idea when it was
# changed by the user from the command line. There is a "restart" command
# which allows explicit specification of command line arguments.
pdb = Pdb()
pdb = Pdb(allow_restart=True)
pdb.rcLines.extend(opts.commands)
while True:
try:
Expand Down
Loading
0