10000 gh-123553: Fix compile warning in `compile.c` by sobolevn · Pull Request #123578 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-123553: Fix compile warning in compile.c #123578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2024
Merged

gh-123553: Fix compile warning in compile.c #123578

merged 1 commit into from
Sep 1, 2024

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Sep 1, 2024 •
edited by bedevere-app bot
Loading

This issue was not fully fixed: #123553

See
Снимок экрана 2024-09-01 в 18 18 26

Local repro:

Python/compile.c:105:12: warning: unused function 'compiler_is_top_level_await' [-Wunused-function]
static int compiler_is_top_level_await(struct compiler *c);
           ^
1 warning generated.

After:

» make
gcc -c -fno-strict-overflow -Wsign-compare -Wunreachable-code -DNDEBUG -g -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include  -fstack-protector-strong -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden  -I./Include/internal -I./Include/internal/mimalloc  -I. -I./Include -I/opt/homebrew/opt/openssl/include -I/opt/homebrew/opt/openssl/include  -DPy_BUILD_CORE -o Python/compile.o Python/compile.c

Refs #123554
CC @Eclips4

@bedevere-app bedevere-app bot mentioned this pull request Sep 1, 2024
Closed
@sobolevn sobolevn enabled auto-merge (squash) September 1, 2024 15:27
Eclips4
Eclips4 approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member
@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the incomplete fix..

@sobolevn sobolevn merged commit 91b7f2e into python:main Sep 1, 2024
39 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows11 Bigmem 3.x has failed when building commit 91b7f2e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1079/builds/4658) and take a look at the build logs.
  4. Check if the failure is related to this commit (91b7f2e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1079/builds/4658

Failed tests:

  • test_hashlib
  • test_zipimport

Failed subtests:

  • testZip64LargeFile - test.test_zipimport.CompressedZipImportTestCase.testZip64LargeFile
  • testZip64LargeFile - test.test_zipimport.UncompressedZipImportTestCase.testZip64LargeFile
  • test_case_md5_uintmax - test.test_hashlib.HashLibTestCase.test_case_md5_uintmax

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\test_zipimport.py", line 923, in testZip64LargeFile
    with open(os_helper.TESTFN, "wb") as f:
         ~~~~^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device


Traceback (test.test_zipimport.UncompressedZipImportTestCase.testTraceback) ... ok


Traceback (most recent call last):
  File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\support\__init__.py", line 1094, in wrapper
    return f(self, maxsize)
  File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\test_hashlib.py", line 551, in test_case_md5_uintmax
    self.check('md5', b'A'*size, '28138d306ff1b8281f1a9067e1a1a2b3')
    ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\test_hashlib.py", line 405, in check
    self.check_file_digest(name, data, hexdigest)
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\test_hashlib.py", line 418, in check_file_digest
    f.write(data)
    ~~~~~~~^^^^^^
OSError: [Errno 28] No space left on device


Traceback (most recent call last):
  File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\test_zipimport.py", line 986, in testZip64LargeFile
    with open(TEMP_ZIP, "wb") as f:
         ~~~~^^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device


Traceback (test.test_zipimport.CompressedZipImportTestCase.testTraceback) ... ok


Traceback (most recent call last):
  File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\test_zipimport.py", line 989, in testZip64LargeFile
    f.seek(offset, os.SEEK_SET)
    ~~~~~~^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New warning: ‘compiler_is_top_level_await’ defined but not used [-Wunused-function]
4 participants
@sobolevn @bedevere-bot @iritkatriel @Eclips4
0