8000 gh-123562: Improve `SyntaxError` message for `case ... as a.b` by sobolevn · Pull Request #123563 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-123562: Improve SyntaxError message for case ... as a.b#123563

Merged
lysnikolaou merged 3 commits intopython:mainfrom
sobolevn:issue-123562
Sep 2, 2024
Merged

gh-123562: Improve SyntaxError message for case ... as a.b#123563
lysnikolaou merged 3 commits intopython:mainfrom
sobolevn:issue-123562

Conversation

@sobolevn
Copy link
Member
@sobolevn sobolevn commented Sep 1, 2024 •
edited by bedevere-app bot
Loading

Notice that there's still a case that is not reported very well, but it is a rather hard one:

>>> match 1:
...     case x as a + 1: ...
...     
  File "<python-input-0>", line 2
    case x as a + 1: ...
                ^
SyntaxError: invalid syntax

This happens because pattern_capture_target actually matches case x as a but not + 1

@bedevere-app bedevere-app bot mentioned this pull request Sep 1, 2024
Closed
@bedevere-app bedevere-app bot added the awaiting core review label Sep 1, 2024
cfbolz
cfbolz reviewed Sep 2, 2024
View reviewed changes
cfbolz
cfbolz approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor
@cfbolz cfbolz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

lysnikolaou
lysnikolaou approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member
@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sobolevn!

@lysnikolaou lysnikolaou merged commit 23f159a into python:main Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfbolz cfbolz cfbolz approved these changes

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@brandtbucher brandtbucher< 59A5 /span> Awaiting requested review from brandtbucher brandtbucher is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @cfbolz @lysnikolaou
0