8000 GH-123545: Remove duplicative `Py_DECREF` when handling `_PyOptimizer_Optimize` errors by savannahostrowski · Pull Request #123546 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-123545: Remove duplicative Py_DECREF when handling _PyOptimizer_Optimize errors #123546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2024
Merged

GH-123545: Remove duplicative Py_DECREF when handling _PyOptimizer_Optimize errors #123546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25654c7
remove duplicative decref
savannahostrowski Aug 29, 2024
dcab85d
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 1, 2024
e565b87
Merge branch 'main' into fix-double-decref
savannahostrowski Sep 1, 2024
c9fac90
Update news entry
savannahostrowski Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2024-09-01-00-02-05.gh-issue-123545.8nQNbL.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a double decref in rare cases on experimental JIT builds.
4 changes: 0 additions & 4 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4739,8 +4739,6 @@ dummy_func(
if (optimized <= 0) {
exit->temperature = restart_backoff_counter(temperature);
if (optimized < 0) {
Py_DECREF(current_executor);
tstate->previous_executor = Py_None;
GOTO_UNWIND();
}
tstate->previous_executor = (PyObject *)current_executor;
Expand Down Expand Up @@ -4822,8 +4820,6 @@ dummy_func(
if (optimized <= 0) {
exit->temperature = restart_backoff_counter(exit->temperature);
if (optimized < 0) {
Py_DECREF(current_executor);
tstate->previous_executor = Py_None;
GOTO_UNWIND();
}
GOTO_TIER_ONE(target);
Expand Down
4 changes: 0 additions & 4 deletions Python/executor_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
0