8000 gh-123463: Include logging_flow.png in PDF docs by bessman · Pull Request #123464 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-123463: Include logging_flow.png in PDF docs #123464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

gh-123463: Include logging_flow.png in PDF docs #123464

merged 1 commit into from
Sep 4, 2024

Conversation

bessman
Copy link
Contributor
@bessman bessman commented Aug 29, 2024 •
edited by github-actions bot
Loading

Use sphinx .. only directive to include logging_flow.png when using latex builder.

📚 Documentation preview 📚: https://cpython-previews--123464.org.readthedocs.build/

@bessman bessman requested a review from vsajip as a code owner August 29, 2024 07:45
@bedevere-app bedevere-app bot mentioned this pull request Aug 29, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 29, 2024
@picnixz picnixz requested a review from AA-Turner August 29, 2024 08:16
encukou
encukou reviewed Sep 2, 2024
View reviewed changes
@bessman @encukou
pythongh-123463: Use raster logging_flow in non-html docs
e3998d6 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bessman bessman force-pushed the fix/doc/logging-flow-latex branch from 3ceed5c to e3998d6 Compare September 4, 2024 06:20
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 4, 2024
@encukou
Copy link
Member
encukou commented Sep 4, 2024

Thank you!
For the future, please avoid rebasing CPython pull requests: removing previous commits means reviewers need to start the review again.
This PR is small enough that it doesn't matter :)

@encukou encukou merged commit 7d2c2f2 into python:main Sep 4, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @bessman for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2024
@bessman @miss-islington
pythongh-123463: Include logging_flow diagram in non-HTML docs (pytho…
cfa752f 
…nGH-123464)

(cherry picked from commit 7d2c2f2)

Co-authored-by: Alexander Bessman <bessman@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Sep 4, 2024

GH-123666 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2024
@bessman @miss-islington
pythongh-123463: Include logging_flow diagram in non-HTML docs (pytho…
6086cda 
…nGH-123464)

(cherry picked from commit 7d2c2f2)

Co-authored-by: Alexander Bessman <bessman@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 4, 2024
@bedevere-app
Copy link
bedevere-app bot commented Sep 4, 2024

GH-123667 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 4, 2024
@bessman bessman deleted the fix/doc/logging-flow-latex branch September 4, 2024 11:50
ambv pushed a commit that referenced this pull request Sep 6, 2024
@miss-islington @bessman
[3.12] gh-123463: Include logging_flow diagram in non-HTML docs (GH-1…
8eef5a8 
…23464) (#123667)

(cherry picked from commit 7d2c2f2)

Co-authored-by: Alexander Bessman <bessman@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Sep 6, 2024
@miss-islington @bessman
[3.13] gh-123463: Include logging_flow diagram in non-HTML docs (GH-1…
402b5f2 
…23464) (#123666)

(cherry picked from commit 7d2c2f2)

Co-authored-by: Alexander Bessman <bessman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bessman @encukou
0