10000 gh-91126: Docs and tests for slotted dataclasses with `__init_subclass__` by sobolevn · Pull Request #123342 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-91126: Docs and tests for slotted dataclasses with __init_subclass__ #123342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2024
Merged

gh-91126: Docs and tests for slotted dataclasses with __init_subclass__ #123342

merged 2 commits into from
Sep 1, 2024

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Aug 26, 2024 •
edited by github-actions bot
Loading

@sobolevn sobolevn requested a review from carljm August 26, 2024 15:38
@sobolevn sobolevn requested a review from ericvsmith as a code owner August 26, 2024 15:38
@bedevere-app bedevere-app bot mentioned this pull request Aug 26, 2024
Closed
@sobolevn sobolevn added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Aug 26, 2024
@sobolevn
Copy link
Member Author

New look: https://cpython-previews--123342.org.readthedocs.build/en/123342/library/dataclasses.html

Снимок экрана 2024-08-26 в 18 45 01

carljm
carljm reviewed Aug 26, 2024
View reviewed changes
Copy link
Member
@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

carljm
carljm approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member
@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sobolevn
Copy link
Member Author

I will wait a bit for @ericvsmith's review and merge it in a couple of days. Thanks!

< 8000 /include-fragment>
@sobolevn sobolevn merged commit 75e7282 into python:main Sep 1, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 1, 2024
@sobolevn @miss-islington
pythongh-91126: Docs and tests for slotted dataclasses with `__init_s…
9265957 
…ubclass__` (pythonGH-123342)

(cherry picked from commit 75e7282)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link
bedevere-app bot commented Sep 1, 2024

GH-123568 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 1, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 1, 2024
@sobolevn @miss-islington
pythongh-91126: Docs and tests for slotted dataclasses with `__init_s…
33a044b 
…ubclass__` (pythonGH-123342)

(cherry picked from commit 75e7282)

Co-authored-by: sobolevn <mail@sobolevn.me>
@sobolevn
Copy link
Member Author
sobolevn commented Sep 1, 2024

One week later - merging :)

@bedevere-app
Copy link
bedevere-app bot commented Sep 1, 2024

GH-123569 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 1, 2024
sobolevn added a commit that referenced this pull request Sep 1, 2024
@miss-islington @sobolevn
[3.12] gh-91126: Docs and tests for slotted dataclasses with `__init_…
12db938 
…subclass__` (GH-123342) (#123569)

gh-91126: Docs and tests for slotted dataclasses with `__init_subclass__` (GH-123342)
(cherry picked from commit 75e7282)

Co-authored-by: sobolevn <mail@sobolevn.me>
@sobolevn sobolevn mentioned this pull request Sep 1, 2024
Closed
sobolevn added a commit that referenced this pull request Sep 1, 2024
@miss-islington @sobolevn
[3.13] gh-91126: Docs and tests for slotted dataclasses with `__init_…
cfdf376 
…subclass__` (GH-123342) (#123568)

gh-91126: Docs and tests for slotted dataclasses with `__init_subclass__` (GH-123342)
(cherry picked from commit 75e7282)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 Refleaks 3.13 has failed when building commit cfdf376.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1407/builds/136) and take a look at the build logs.
  4. Check if the failure is related to this commit (cfdf376) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1407/builds/136

Failed subtests:

  • test_create_connection_local_addr_skip_different_family - test.test_asyncio.test_events.EPollEventLoopTests.test_create_connection_local_addr_skip_different_family

Summary of the results of the build (if available):

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/test_asyncio/test_events.py", line 694, in test_create_connection_local_addr_skip_different_family
    with self.assertRaises(OSError):
        self.loop.run_until_complete(f)
AssertionError: OSError not raised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @bedevere-bot @carljm
0