T_CHAR

python · colesbury · Dec 3, 2024 · Aug 21, 2024 · Aug 21, 2024 · Aug 22, 2024
commit bce02d0d02b28a533c8cef18a72bf41c5e50669b
diff --git a/Python/structmember.c b/Python/structmember.c
@@ -24,6 +24,7 @@ PyObject *
 PyMember_GetOne(const char *obj_addr, PyMemberDef *l)
 {
     PyObject *v;
+    char value;
     if (l->flags & Py_RELATIVE_OFFSET) {
         PyErr_SetString(
             PyExc_SystemError,
@@ -80,7 +81,9 @@ PyMember_GetOne(const char *obj_addr, PyMemberDef *l)
         v = PyUnicode_FromString((char*)addr);
         break;
     case Py_T_CHAR:
-            v = PyUnicode_FromStringAndSize((char*)addr, 1);
+        // case ...: char value = ... requires a C23-compatible compiler
+        value = FT_ATOMIC_LOAD_CHAR_RELAXED(*(char *) addr);
+        v = PyUnicode_FromStringAndSize(&value, 1);
         break;
     case _Py_T_OBJECT:
         v = *(PyObject **)addr;
@@ -318,7 +321,7 @@ PyMember_SetOne(char *addr, PyMemberDef *l, PyObject *v)
             PyErr_BadArgument();
             return -1;
         }
-        *(char*)addr = string[0];
+        FT_ATOMIC_STORE_CHAR_RELEASE(*(char*)addr, string[0]);
         break;
         }
     case Py_T_STRING: