8000 GH-121723: Skip `test_config_queue_handler_multiprocessing_context` in emulated JIT CI by picnixz · Pull Request #122969 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-121723: Skip test_config_queue_handler_multiprocessing_context in emulated JIT CI #122969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2024
Merged

GH-121723: Skip test_config_queue_handler_multiprocessing_context in emulated JIT CI #122969

merged 3 commits into from
Aug 13, 2024

Conversation

picnixz
Copy link
Member
@picnixz picnixz commented Aug 13, 2024 •
edited by bedevere-app bot
Loading

The test in question requires multiprocessing managers but the test failed since then:

https://github.com/python/cpython/actions/workflows/jit.yml

example logs: https://github.com/python/cpython/actions/runs/10358273944/job/28672370717

ERROR: test_config_queue_handler_multiprocessing_context (test.test_logging.ConfigDictTest.test_config_queue_handler_multiprocessing_context) (start_method='fork')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_logging.py", line 4014, in test_config_queue_handler_multiprocessing_context
    q = manager.Queue()
  File "/home/runner/work/cpython/cpython/Lib/multiprocessing/managers.py", line 729, in temp
    token, exp = self._create(typeid, *args, **kwds)
                 ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/cpython/cpython/Lib/multiprocessing/managers.py", line 609, in _create
    conn = self._Client(self._address, authkey=self._authkey)
  File "/home/runner/work/cpython/cpython/Lib/multiprocessing/connection.py", line 525, in Client
    answer_challenge(c, authkey)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/runner/work/cpython/cpython/Lib/multiprocessing/connection.py", line 953, in answer_challenge
    message = connection.recv_bytes(256)         # reject large message
  File "/home/runner/work/cpython/cpython/Lib/multiprocessing/connection.py", line 216, in recv_bytes
    buf = self._recv_bytes(maxlength)
  File "/home/runner/work/cpython/cpython/Lib/multiprocessing/connection.py", line 430, in _recv_bytes
    buf = self._recv(4)
  File "/home/runner/work/cpython/cpython/Lib/multiprocessing/connection.py", line 395, in _recv
    chunk = read(handle, remaining)
ConnectionResetError: [Errno 104] Connection reset by peer

I don't know the exact reason but I assume it's because it's on emulated linux. Other tests that use multiprocessing queues were already disabled for (probably) the same reasons:

  • test.test_logging.ConfigDictTest.test_config_queue_handler
  • test.test_logging.ConfigDictTest.test_multiprocessing_queues

NB: I took the liberty of fixing a whitespace that I forgot.
NB2: the original issue is #121723 but I'm not sure whether I should put it in the title or not.

@picnixz picnixz requested a review from brandtbucher as a code owner August 13, 2024 14:05
@picnixz picnixz requested a review from vsajip August 13, 2024 14:06
@picnixz picnixz added skip issue skip news tests Tests in the Lib/test dir labels Aug 13, 2024
@picnixz picnixz added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Aug 13, 2024
@brandtbucher brandtbucher removed the needs backport to 3.12 only security fixes label Aug 13, 2024
@brandtbucher brandtbucher changed the title [CI/JIT] fix aarch64-unknown-linux-gnu logging tests 121723: Skip test_config_queue_handler_multiprocessing_context in emulated JIT CI Aug 13, 2024
brandtbucher
brandtbucher approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member
@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Doesn't need to be backported to 3.12, there's no JIT there.

@brandtbucher brandtbucher self-assigned this Aug 13, 2024
@brandtbucher brandtbucher changed the title 121723: Skip test_config_queue_handler_multiprocessing_context in emulated JIT CI GH-121723: Skip test_config_queue_handler_multiprocessing_context in emulated JIT CI Aug 13, 2024
@bedevere-app bedevere-app bot mentioned this pull request Aug 13, 2024
Closed
@brandtbucher brandtbucher merged commit 7b8328b into python:main Aug 13, 2024
64 checks passed
@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@brandtbucher brandtbucher changed the title GH-121723: Skip test_config_queue_handler_multiprocessing_context in emulated JIT CI GH-121723: Skip test_config_queue_handler_multiprocessing_context in emulated JIT CI Aug 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2024
@picnixz @miss-islington
pythonGH-121723: Skip test_config_queue_handler_multiprocessing_conte…
fd9fe9a 
…xt in emulated JIT CI (pythonGH-122969)

(cherry picked from commit 7b8328b)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Aug 13, 2024

GH-122991 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 13, 2024
@picnixz picnixz deleted the fix-jit-aarch64-unknown-linux branch August 14, 2024 06:04
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@picnixz @blhsing
pythonGH-121723: Skip test_config_queue_handler_multiprocessing_conte…
7c77db2 
…xt in emulated JIT CI (python#122969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

@brandtbucher brandtbucher

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picnixz @vsajip @brandtbucher
0