Polishing.

python · serhiy-storchaka · Nov 7, 2024 · Aug 8, 2024 · Aug 12, 2024 · Aug 12, 2024
commit e38d94ed7a1852ddf1b9d640a7653c6e7bb26a09
diff --git a/Modules/clinic/_testclinic.c.h b/Modules/clinic/_testclinic.c.h
@@ -230,9 +230,7 @@ gc_get_referrers_impl(PyObject *module, PyObject *objs)
     }
 
     PyInterpreterState *interp = _PyInterpreterState_GET();
-    PyObject *result = _PyGC_GetReferrers(interp, objs);
-
-    return result;
+    return _PyGC_GetReferrers(interp, objs);
 }
 
 /* Append obj to list; return true if error (out of memory), false if OK. */

@@ -312,7 +312,7 @@ def render(self, parameter: Parameter, data: CRenderData) -> None:
     def length_name(self) -> str:
         """Computes the name of the associated "length" variable."""
         assert self.length is not None
-        return self.parser_name.removeprefix(libclinic.CLINIC_PREFIX) + "_length"
+        return self.name + "_length"
 
     # Why is this one broken out separately?
     # For "positional-only" function parsing,

@@ -1237,9 +1237,6 @@ class varpos_tuple_converter(CConverter):
     format_unit = ''
     c_default = 'NULL'
 
-    def converter_init(self) -> None:
-        pass
-
     def cleanup(self) -> str:
         return f"""Py_XDECREF({self.parser_name});\n"""
 
@@ -1252,9 +1249,6 @@ class varpos_array_converter(CConverter):
     length = True
     c_ignored_default = ''
 
-    def converter_init(self) -> None:
-        pass
-
     def parse_arg(self, argname: str, displayname: str, *, limited_capi: bool) -> str | None:
         raise AssertionError('should never be called')
 

@@ -461,7 +461,7 @@ def _parse_vararg(self) -> str:
             size = 'nargs' if self.fastcall else 'PyTuple_GET_SIZE(args)'
             if self.max_pos:
                 if min(self.pos_only, self.min_pos) < self.max_pos:
-                    start = f'{start} + Py_MIN({size}, {self.max_pos})'
+                    start = f'{size} > {self.max_pos} ? {start} + {self.max_pos} : {start}'
                     size = f'Py_MAX(0, {size} - {self.max_pos})'
                 else:
                     start = f'{start} + {self.max_pos}'