8000 GH-122390: Replace `_Py_GetbaseOpcode` with `_Py_GetBaseCodeUnit` by markshannon · Pull Request #122942 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-122390: Replace _Py_GetbaseOpcode with _Py_GetBaseCodeUnit #122942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 13, 2024
Merged

GH-122390: Replace _Py_GetbaseOpcode with _Py_GetBaseCodeUnit #122942

merged 5 commits into from
Aug 13, 2024

Conversation

markshannon
Copy link
Member
@markshannon markshannon commented Aug 12, 2024 •
edited by bedevere-app bot
Loading

This PR:

  • Ensures we account for ENTER_EXECUTOR and instrumentation whenever we need to fetch the underlying instruction.
  • Moves ENTER_EXECUTOR to opcode 255, to keep the common path fast in _Py_GetBaseCodeUnit.
  • Does a bit of tidying up around calls to _Py_GetBaseCodeUnit as we don't need the additional checks any more.

@bedevere-app bedevere-app bot mentioned this pull request Aug 12, 2024
Closed
iritkatriel
iritkatriel reviewed Aug 13, 2024
View reviewed changes
@markshannon
Copy link
Member Author

Failures on emulated JIT builds are a known issue.

@markshannon markshannon merged commit 7a65439 into python:main Aug 13, 2024
63 of 65 checks passed
@markshannon markshannon deleted the get-base-instruction branch August 14, 2024 10:04
@AA-Turner AA-Turner mentioned this pull request Aug 14, 2024
Merged
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@markshannon @blhsing
pythonGH-122390: Replace _Py_GetbaseOpcode with `_Py_GetBaseCodeUni…
03a8301 
…t` (pythonGH-122942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@ericsnowcurr 56FE ently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markshannon @iritkatriel
0