8000 gh-122881: Reduce asyncio heapq scheduling overhead by bdraco · Pull Request #122882 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-122881: Reduce asyncio heapq scheduling overhead #122882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

gh-122881: Reduce asyncio heapq scheduling overhead #122882

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
564394e
Reduce asyncio heapq scheduling overhead
bdraco Aug 10, 2024
3b46d71
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 10, 2024
f01857d
Update Lib/asyncio/base_events.py
bdraco Aug 10, 2024
a866d33
Update Misc/NEWS.d/next/Library/2024-08-10-13-10-45.gh-issue-122881.z…
bdraco Aug 10, 2024
0205d0b
Update Misc/NEWS.d/next/Library/2024-08-10-13-10-45.gh-issue-122881.z…
bdraco Aug 11, 2024
fdda416
tweaks from review comments
bdraco Aug 11, 2024
88a04d4
Merge remote-tracking branch 'bdraco/speed_up_async_schedule' into sp…
bdraco Aug 11, 2024
345c939
Merge branch 'main' into speed_up_async_schedule
bdraco Aug 11, 2024
4b9aed8
tweak from suggestion
bdraco Aug 12, 2024
6753682
Merge branch 'main' into speed_up_async_schedule
bdraco Aug 12, 2024
ca5cc25
TimerHandle scheduling can be quantified, _run_once imporvement will …
bdraco Aug 12, 2024
a5b6647
access self more often
bdraco Aug 12, 2024
5ccc55f
Merge branch 'main' into speed_up_async_schedule
bdraco Aug 24, 2024
f78838c
Update Lib/asyncio/base_events.py
bdraco Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
access self more often
  • Loading branch information
@bdraco
bdraco committed Aug 12, 2024
commit a5b66476566019f2b643a61b5fd815d5b3276e84
19 changes: 8 additions & 11 deletions Lib/asyncio/base_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1980,14 +1980,12 @@ def _run_once(self):
handle._scheduled = False

timeout = None
ready = self._ready
scheduled = self._scheduled

if ready or self._stopping:
if self._ready or self._stopping:
timeout = 0
elif scheduled:
elif self._scheduled:
# Compute the desired timeout.
timeout = scheduled[0][0] - self.time()
timeout = self._scheduled[0][0] - self.time()
if timeout > MAXIMUM_SELECT_TIMEOUT:
timeout = MAXIMUM_SELECT_TIMEOUT
elif timeout < 0:
Expand All @@ -2000,21 +1998,20 @@ def _run_once(self):

# Handle 'later' callbacks that are ready.
end_time = self.time() + self._clock_resolution
while scheduled and scheduled[0][0] < end_time:
_, handle = heapq.heappop(scheduled)
while self._scheduled and self._scheduled[0][0] < end_time:
_, handle = heapq.heappop(self._scheduled)
handle._scheduled = False
ready.append(handle)
self._ready.append(handle)

# This is the only place where callbacks are actually *called*.
# All other places just add them to ready.
# Note: We run all currently scheduled callbacks, but not any
# callbacks scheduled by callbacks run this time around --
# they will be run the next time (after another I/O poll).
# Use an idiom that is thread-safe without using locks.
ntodo = len(ready)
ready_popleft = ready.popleft
ntodo = len(self._ready)
for i in range(ntodo):
handle = ready_popleft()
handle = self._ready.popleft()
if handle._cancelled:
continue
if self._debug:
Expand Down
Loading
0