bpo-30122: Added missing archive programs. #1228
Conversation
|
@AraHaan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @briancurtin and @serhiy-storchaka to be potential reviewers. |
Doc/faq/windows.rst
Outdated
| CPython 3.3. | ||
| an ":kbd:`Enter`" or type ``exit()`` in the interpreter to get out of it). | ||
| Once you have verified the directory, you can add it to the system path to make | ||
| it easier to start Python by just running the ``python`` command. This is |
There was a problem hiding this comment.
There should be two spaces after the period.
|
@lulouie alright on it now. |
Doc/faq/windows.rst
Outdated
| @@ -343,3 +343,6 @@ Simply rename the downloaded file to have the .TGZ extension, and WinZip will be | |||
| able to handle it. (If your copy of WinZip doesn't, get a newer one from | |||
| https://www.winzip.com.) | |||
|
|
|||
| If you do not like or have WinZip or if you do not want to buy a copy of it | |||
There was a problem hiding this comment.
I don't have Windows. Is there no built-in zip utility app for Windows?
In the previous paragraph, maybe instead we should remove the reference to specific third party tools, and just say "file compression tool" (or whatever it's called on Windows).
There was a problem hiding this comment.
That is true, however the built in zip utility does not support TGZ files that I know of. But I agree though as windows does have an built in zip file compressor.
There was a problem hiding this comment.
Alright changed it to say for them to use their favorite file compression manager
Doc/faq/windows.rst
Outdated
|
|
||
| Simply rename the downloaded file to have the .TGZ extension, and your | ||
| favorite file compression manager should be able to handle it. If not look | ||
| for a newer version that does it/this. |
There was a problem hiding this comment.
I think we should continue to mention something specific (possibly still winzip), though it would be reasonable to add "or your favorite archive program". It is so hard to know what software is "good software" and what is virus-ware, and where to get safe copies of the good ones, in the windows world. (I just went through this myself, and ended up downloading 7-zip, but frankly getting it, unsigned, from sourceforge made me nervous even though I was installing it in a VM).
Doc/faq/windows.rst
Outdated
| add it to the system path to make it easier to start Python by just running | ||
| the ``python`` command. This is currently an option in the installer as of | ||
| CPython 3.3. | ||
| an ":kbd:`Enter`" or type ``exit()`` in the interpreter to get out of it). |
There was a problem hiding this comment.
I think adding a mention of 'exit()' here just confuses the exposition. I recommend against this change.
|
Ok then, will update it when I get back to my laptop at about 1 PM my time. It is 8:38 AM rn. |
|
Alright back. |
Changed compression manager docs from only WinZip to favorite one perfered with WinZip.
|
I would pefer to suggest 7zip which is free rather WinZip which is a shareware. |
|
Alright |
|
ok, changed. |
|
Actually, I dont think this is still even needed at all in the docs Maybe I can get away with removing that whole paragraph instead. I am not sure if the bug the paragraph stated still exists or not. |
|
@Haypo what you think on the current commit? |
Doc/faq/windows.rst
Outdated
| @@ -329,17 +329,11 @@ Prior to Python 2.7 and 3.2, to terminate a process, you can use :mod:`ctypes`:: | |||
|
|
|||
| In 2.7 and 3.2, :func:`os.kill` is implemented similar to the above function, | |||
| with the additional feature of being able to send :kbd:`Ctrl+C` and :kbd:`Ctrl+Break` | |||
| to console subprocesses which are designed to handle those signals. See | |||
| to console subprocesses which are designed to handle those signals. See | |||
| :func:`os.kill` for further details. | |||
There was a problem hiding this comment.
Suggest removing this whitespace change, adds noise.
| https://www.winzip.com.) | ||
|
|
||
| Use 7zip or your favorite archive program to handle the downloaded documentation | ||
| package. If not look for a newer version that does. |
There was a problem hiding this comment.
This new wording seems okay to me. Windows built-in archive support cannot handle .tgz. 7zip is probably the preferred tool but any decent archive program like WinZip or WinRAR should handle it too. The note about .EXE extensions seems unnecessary. I've never seen a Windows browser do that but maybe they did at some point. I'd guess that is useless historical trivia at this point.
|
Is this about ready to merge yet? Any other changes you guys want me to make? |
|
@bitdancer, @nascheme think this is ready to merge? Edit: I wonder what happened to the fork this was on and the branch. RIP |
|
LGTM |
|
uh @nascheme It looks like since I cant commit to the repo this PR was on anymore I think you might have to somehow get the diff to this one, and then make an news entry (if needed) and then merge (or merge it like it is somehow) it seems that appveyor and the news bot are having issues with this pr on my iPhone. |
|
To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request. If/when the requested changes have been made, please leave a comment that says, |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @bitdancer: please review the changes made to this pull request. |
|
Hopefully this can get merged since I lost the fork this was on somehow. Most likely I deleted the fork and forgot It was for this pull request. |
|
This paragraph does no longer exists since 5719f27. |
Changed compression manager docs from only WinZip to favorite one perfered with WinZip.