8000 gh-122681: remove m_atan2()/c_atan2() helpers by skirpichev · Pull Request #122715 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-122681: remove m_atan2()/c_atan2() helpers #122715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 17, 2024
Merged

gh-122681: remove m_atan2()/c_atan2() helpers #122715

merged 3 commits into from
Aug 17, 2024

Conversation

skirpichev
Copy link
Contributor
@skirpichev skirpichev commented Aug 6, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Aug 6, 2024
Closed
@skirpichev skirpichev mentioned this pull request Aug 6, 2024
Merged
@skirpichev

This comment was marked as outdated.

Sign in to view
@vstinner
Copy link
Member
vstinner commented Aug 6, 2024

Can you rebase/merge your branch to avoid the merge conflict? Then I can run buildbots on this PR.

@skirpichev skirpichev marked this pull request as ready for review August 6, 2024 12:52
@skirpichev

This comment was marked as outdated.

Sign in to view
@vstinner vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit a4aff45 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2024
@skirpichev
Copy link
Contributor Author

No failures, related to this pr.

vstinner
vstinner approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@skirpichev: Did you just create to see if removing the wrapper would work or not, or do you propose to remove it?

@skirpichev
Copy link
Contributor Author

Yeah, I think we can remove it; testing with buildbots - for additional safety. But it's not urgent and I would appreciate @mdickinson blessing.

Current workarounds fix only few functions in cmath. Missing bugreports - another indication, that underlying problems were fixed on affected systems.

@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 17, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 11a6f3d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 17, 2024
@kumaraditya303 kumaraditya303 merged commit 19be0ee into python:main Aug 17, 2024
103 of 108 checks passed
@skirpichev skirpichev deleted the remove-atan2-helpers-122681 branch August 17, 2024 08:26
jeremyhylton pushed a commit to jeremyhylton/cpython that referenced this pull request Aug 19, 2024
@skirpichev @jeremyhylton
pythongh-122681: remove m_atan2()/c_atan2() helpers (python#122715)
a5f57ab
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@skirpichev @blhsing
pythongh-122681: remove m_atan2()/c_atan2() helpers (python#122715)
d7d56eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skirpichev @vstinner @bedevere-bot @kumaraditya303
0