8000 gh-112301: Add Warning Count to Warning Check Tooling by nohlson · Pull Request #122711 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-112301: Add Warning Count to Warning Check Tooling #122711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Aug 14, 2024
Merged

gh-112301: Add Warning Count to Warning Check Tooling #122711

Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
5148727
Create simple warning check tool and add to ubuntu build and test job
nohlson Jul 13, 2024
3bd5a10
Add flags to check warnings script to fail on regression or improvement
nohlson Jul 13, 2024
6813003
Remove redundant comment
nohlson Jul 13, 2024
ab4d754
Rename warnigore file to warningignore
nohlson Jul 13, 2024
615d228
Use regex to extract json arrays
nohlson Jul 13, 2024
fc0a60b
Trim whitespace
nohlson Jul 13, 2024
7793d80
Test on github unexpected improvement
nohlson Jul 13, 2024
99715d2
Add config for improve fail check
nohlson Jul 13, 2024
bc44ec2
Revert to prod check warning state
nohlson Jul 13, 2024
e2ca75f
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 13, 2024
bd1634e
Refactor creating set of files with warnings to a dedicated function
nohlson Jul 17, 2024
b07b1d6
Move cflags configure option to top level build configuration
nohlson Jul 23, 2024
e1954a5
Add json diagnostics to ubuntu configuration as first argument
nohlson Jul 23, 2024
5935143
Add newline to news
nohlson Jul 23, 2024
7f1a238
Create simple warning check tool and add to ubuntu build and test job
nohlson Jul 13, 2024
144136e
Add macos warning checks to GitHub actions
nohlson Jul 22, 2024
3dd40fd
Revert reusable-macos.yml for environment variables
nohlson Jul 22, 2024
1158f53
Update paths
nohlson Jul 22, 2024
cb51b4f
Test unexpected improvement
nohlson Jul 22, 2024
77e0f6e
Remove warning ignore
nohlson Jul 22, 2024
3e1d75f
Add json output option to macos configure job
nohlson Jul 22, 2024
b5cd58a
Add common dictionary format when parsing warnings
nohlson Jul 23, 2024
02f313e
Remove configure option for macos job
nohlson Jul 23, 2024
83d1ed7
Print out json version of compiler output
nohlson Jul 23, 2024
08a6f6d
Remove old version of warning ignore file
nohlson Jul 23, 2024
7be8ee6
Remove compiler output print diagnostic
nohlson Jul 24, 2024
8b0a2ee
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 24, 2024
49cbd87
Remove superfluous comment
nohlson Jul 24, 2024
522f27c
oMerge branch 'main' into add-macos-warnings-tracking-tooling
nohlson Jul 30, 2024
b654a84
Add period to news
nohlson Jul 30, 2024
7780da6
Merge branch 'main' into add-macos-warnings-tracking-tooling
nohlson Jul 31, 2024
3688c5c
Make warning ignore file optional
nohlson Jul 31, 2024
cb1f276
Add write compiler output to log and file
nohlson Jul 31, 2024
fb91e3e
Fix formatting and update regex
nohlson Jul 31, 2024
f35ba60
Fix comment formatting
nohlson Aug 5, 2024
294dd61
Add warning count to check warnigns tooling
nohlson Aug 5, 2024
4056985
Remove duplicate warnings from check warning tooling
nohlson Aug 5, 2024
dad672b
Merge branch 'main' into add-warning-count-to-warning-ignore-files
nohlson Aug 5, 2024
4164b81
Trim trailing whitespace
nohlson Aug 6, 2024
8b07ae8
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 6, 2024
17858b9
Reformat news
nohlson Aug 6, 2024
f483e04
Merge branch 'main' into add-warning-count-to-warning-ignore-files
nohlson Aug 6, 2024
55e20bd
Update helpers for function argument types
nohlson Aug 6, 2024
566e8cd
Format line length
nohlson Aug 6, 2024
f8ae75e
Use named tuple for warning filename and count
nohlson Aug 12, 2024
cbf069b
Use proper type
nohlson Aug 12, 2024
26b40d3
Update function signatures and make files with expected warnings list…
nohlson Aug 13, 2024
ca519a3
Update Tools/build/check_warnings.py
nohlson Aug 14, 2024
f370442
Update Tools/build/check_warnings.py
nohlson Aug 14, 2024
644c117
Add parsing of option from clang output
nohlson Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Trim whitespace
  • Loading branch information
@nohlson
nohlson committed Jul 23, 2024
commit fc0a60ba7e6a902b0abd17faa30b18c97f1ad90c
2 changes: 1 addition & 1 deletion Tools/build/check_warnings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def main(argv: list[str] | None = None) -> int:

status = get_unexpected_improvements(warnings, files_with_expected_warnings)
if args.fail_on_improvement: exit_code |= status

return exit_code

if __name__ == "__main__":
Expand Down
0