8000 gh-122686: pin attrs package (for hypothesis workflow) by skirpichev · Pull Request #122687 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-122686: pin attrs package (for hypothesis workflow) #122687

New 8000 issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 6, 2024
Merged

gh-122686: pin attrs package (for hypothesis workflow) #122687

merged 3 commits into from
Aug 6, 2024

Conversation

skirpichev
Copy link
Contributor
@skirpichev skirpichev commented Aug 5, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Aug 5, 2024
Closed
@hugovk
Copy link
Member
hugovk commented Aug 5, 2024

Do we still need to pin if upgrading to latest hypothesis==6.108.8?

If so, please can you add a comment as to why we're adding an attrs pin?

@skirpichev
Copy link
Contributor Author

Do we still need to pin if upgrading to latest hypothesis==6.108.8?

Yes, I think so. See:
https://github.com/python/cpython/actions/runs/10246311678/job/28343157458

If so, please can you add a comment as to why we're adding an attrs pin?

I did no debugging, but new release seems broken on the CPython main. Pinning "just works", e.g. (see last commit):
#122682

I'll open issue for attrs and add a comment with reference.

vstinner
vstinner approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev @vstinner
Update Tools/requirements-hypothesis.txt
362bc7a 
Co-authored-by: Victor Stinner <vstinner@python.org>
@skirpichev skirpichev mentioned this pull request Aug 6, 2024
Merged
@hugovk hugovk merged commit 35ae4aa into python:main Aug 6, 2024
32 checks passed
@skirpichev skirpichev deleted the pin-attrs-122686 branch August 6, 2024 03:58
@hugovk
Copy link
Member
hugovk commented Aug 6, 2024

Thanks!

brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@skirpichev @vstinner @brandtbucher
pythongh-122686: Pin attrs package (for Hypothesis workflow) (python#…
f8a12de 
…122687)

Co-authored-by: Victor Stinner <vstinner@python.org>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@skirpichev @vstinner @blhsing
pythongh-122686: Pin attrs package (for Hypothesis workflow) (python#…
785718e 
…122687)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skirpichev @hugovk @vstinner
0