8000 [3.13] Add the Python 3.13 abidump, and enable the ABI check. by Yhg1s · Pull Request #122583 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.13] Add the Python 3.13 abidump, and enable the ABI check. #122583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 2, 2024
Merged

[3.13] Add the Python 3.13 abidump, and enable the ABI check. #122583

merged 5 commits into from
Aug 2, 2024

Conversation

Yhg1s
Copy link
Member
@Yhg1s Yhg1s commented Aug 1, 2024 •
edited by github-actions bot
Loading

Now that we're in release-candidate mode, add the Python 3.13 ABI dump file, and enable the ABI check workflow. (Copied from the 3.12 workflow with s/ubuntu-22.04/ubuntu-latest/ since that seems to be the fashion now.)

📚 Documentation preview 📚: https://cpython-previews--122583.org.readthedocs.build/

hugovk
hugovk reviewed Aug 1, 2024
View reviewed changes
Yhg1s and others added 4 commits August 2, 2024 00:29
@Yhg1s @hugovk
Update .github/workflows/build.yml
2a8ffab 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@Yhg1s @hugovk
Update .github/workflows/build.yml
814b51d 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@Yhg1s @hugovk
Update .github/workflows/build.yml
e1d1d67 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@Yhg1s @hugovk
Update .github/workflows/build.yml
cfdc5b5 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@Yhg1s
Copy link
Member Author
Yhg1s commented Aug 1, 2024

Should those changes be made to 3.12 as well?

@hugovk
Copy link
Member
hugovk commented Aug 2, 2024

The actions have already been updated in 3.12 (#116948).

The URL update doesn't seem important enough on its own, there's a redirect in place.

encukou
encukou approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member
@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With ubuntu-latest we might get spurious ABI complaints when Ubuntu updates. But it's just one of the ways that update might bite us, and this one should be easy to solve/revisit.

@Yhg1s Yhg1s merged commit 9f488f9 into python:3.13 Aug 2, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

@hugovk hugovk hugovk approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yhg1s @hugovk @encukou
0