8000 gh-122431: Disallow negative values in `readline.append_history_file` by ZeroIntensity · Pull Request #122469 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content
/ cpython Public

gh-122431: Disallow negative values in readline.append_history_file #122469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 5, 2024
Merged

gh-122431: Disallow negative values in readline.append_history_file #122469

merged 7 commits into from
Dec 5, 2024

Conversation

@ZeroIntensity
Copy link
Member
@ZeroIntensity ZeroIntensity commented Jul 30, 2024

FWIW, this is actually a bug upstream in GNU's append_history function, but this is the best that Python can do in the meantime to prevent accessing out of bounds memory.

@bedevere-app bedevere-app bot mentioned this pull request Jul 30, 2024
Closed
@ZeroIntensity ZeroIntensity changed the title gh-122431: Disallow negative values in readline.append_history_file. gh-122431: Disallow negative values in readline.append_history_file Jul 30, 2024
@ZeroIntensity
Reword NEWS entry.
479c00a 
Really, this is just a commit to retrigger CI.
@ZeroIntensity
Copy link
Member Author
ZeroIntensity commented Jul 30, 2024

I'm quite confused on how the documentation tests could be related.

vstinner
vstinner reviewed Dec 5, 2024
View reviewed changes
@ZeroIntensity @vstinner
Apply suggestions from code review
409a5ea 
Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner enabled auto-merge (squash) December 5, 2024 15:47
@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Dec 5, 2024
vstinner
vstinner approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update.

@vstinner vstinner merged commit 208b0fb into python:main Dec 5, 2024
49 checks passed
@miss-islington-app
Copy link
miss-islington-app bot commented Dec 5, 2024

Thanks @ZeroIntensity for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2024
@ZeroIntensity @vstinner @miss-islington
pythongh-122431: Disallow negative values in `readline.append_history…
685956c 
…_file` (pythonGH-122469)

(cherry picked from commit 208b0fb)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2024
@ZeroIntensity @vstinner @miss-islington
pythongh-122431: Disallow negative values in `readline.append_history…
5bda4e2 
…_file` (pythonGH-122469)

(cherry picked from commit 208b0fb)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link
bedevere-app bot commented Dec 5, 2024

GH-127641 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 5, 2024
@bedevere-app
Copy link
bedevere-app bot commented Dec 5, 2024

GH-127642 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 5, 2024
vstinner added a commit that referenced this pull request Dec 5, 2024
@miss-islington @ZeroIntensity @vstinner
[3.12] gh-122431: Disallow negative values in `readline.append_histor…
a65475f 
…y_file` (GH-122469) (#127642)

gh-122431: Disallow negative values in `readline.append_history_file` (GH-122469)
(cherry picked from commit 208b0fb)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Dec 5, 2024
@miss-islington @ZeroIntensity @vstinner
[3.13] gh-122431: Disallow negative values in `readline.append_histor…
468e8da 
…y_file` (GH-122469) (#127641)

gh-122431: Disallow negative values in `readline.append_history_file` (GH-122469)
(cherry picked from commit 208b0fb)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@ZeroIntensity @vstinner @srinivasreddy
pythongh-122431: Disallow negative values in `readline.append_history…
2c29398 
…_file` (python#122469)

Co-authored-by: Victor Stinner <vstinner@python.org>
@ZeroIntensity ZeroIntensity mentioned this pull request Oct 23, 2025
Closed
@ZeroIntensity ZeroIntensity deleted the segfault-readline-fix branch October 23, 2025 01:44
Sign up for free to join 5F58 this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroIntensity @vstinner
0