8000 gh-120974: Make asyncio `swap_current_task` safe in free-threaded build by colesbury · Pull Request #122317 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-120974: Make asyncio swap_current_task safe in free-threaded build #122317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2024
Merged

gh-120974: Make asyncio swap_current_task safe in free-threaded build #122317

merged 2 commits into from
Aug 2, 2024

Conversation

colesbury
Copy link
Contributor
@colesbury colesbury commented Jul 26, 2024 •
edited by bedevere-app bot
Loading

Use a critical section around the modifications to current_tasks so that the swapping is atomic.

@colesbury
pythongh-120974: Make asyncio swap_current_task safe in free-thread…
846f6f8 
…ed build

Use a critical section around the modifications to `current_tasks`.
@colesbury colesbury added skip news needs backport to 3.13 bugs and security fixes labels Jul 26, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 26, 2024
Closed
@colesbury
Copy link
Contributor Author

!buildbot nogil refleaks

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 846f6f8 🤖

The command will test the builders whose names match following regular expression: nogil refleaks

The builders matched are:

  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • AMD64 Ubuntu NoGIL Refleaks PR

kumaraditya303
kumaraditya303 reviewed Jul 27, 2024
View reviewed changes
@colesbury colesbury requested a review from kumaraditya303 July 29, 2024 16:52
@kumaraditya303 kumaraditya303 merged commit b5e6fb3 into python:main Aug 2, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@bedevere-app bedevere-app bot removed the awaiting merge label Aug 2, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 2, 2024
@colesbury @miss-islington
pythongh-120974: Make asyncio swap_current_task safe in free-thread…
6a87edc 
…ed build (pythonGH-122317)

* pythongh-120974: Make asyncio `swap_current_task` safe in free-threaded build
(cherry picked from commit b5e6fb3)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Aug 2, 2024

GH-122612 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 2, 2024
kumaraditya303 pushed a commit that referenced this pull request Aug 2, 2024
@miss-islington @colesbury
[3.13] gh-120974: Make asyncio swap_current_task safe in free-threa…
c1efeb3 
…ded build (GH-122317) (#122612)

gh-120974: Make asyncio `swap_current_task` safe in free-threaded build (GH-122317)

* gh-120974: Make asyncio `swap_current_task` safe in free-threaded build
(cherry picked from commit b5e6fb3)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.13 has failed when building commit c1efeb3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1386/builds/461) and take a look at the build logs.
  4. Check if the failure is related to this commit (c1efeb3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1386/builds/461

Failed tests:

  • test_httplib

Failed subtests:

  • testHTTPConnectionSourceAddress - test.test_httplib.SourceAddressTest.testHTTPConnectionSourceAddress

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/0CD06645-FC15-4514-B5DC-AEF3ED24C912/data/Containers/Bundle/Application/1AE2CD3C-EBB6-482B-B920-80647D6C686A/iOSTestbed.app/python/lib/python3.13/test/test_httplib.py", line 1778, in testHTTPConnectionSourceAddress
    self.conn.connect()
    ~~~~~~~~~~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/0CD06645-FC15-4514-B5DC-AEF3ED24C912/data/Containers/Bundle/Application/1AE2CD3C-EBB6-482B-B920-80647D6C686A/iOSTestbed.app/python/lib/python3.13/http/client.py", line 1001, in connect
    self.sock = self._create_connection(
                ~~~~~~~~~~~~~~~~~~~~~~~^
        (self.host,self.port), self.timeout, self.source_address)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/0CD06645-FC15-4514-B5DC-AEF3ED24C912/data/Containers/Bundle/Application/1AE2CD3C-EBB6-482B-B920-80647D6C686A/iOSTestbed.app/python/lib/python3.13/socket.py", line 864, in create_connection
    raise exceptions[0]
  File "/Users/buildbot/Library/Developer/XCTestDevices/0CD06645-FC15-4514-B5DC-AEF3ED24C912/data/Containers/Bundle/Application/1AE2CD3C-EBB6-482B-B920-80647D6C686A/iOSTestbed.app/python/lib/python3.13/socket.py", line 848, in create_connection
    sock.bind(source_address)
    ~~~~~~~~~^^^^^^^^^^^^^^^^
OSError: [Errno 48] Address already in use

brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@colesbury @brandtbucher
pythongh-120974: Make asyncio swap_current_task safe in free-thread…
475aeda 
…ed build (python#122317)

* pythongh-120974: Make asyncio `swap_current_task` safe in free-threaded build
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@colesbury @blhsing
pythongh-120974: Make asyncio swap_current_task safe in free-thread…
d3909a4 
…ed build (python#122317)

* pythongh-120974: Make asyncio `swap_current_task` safe in free-threaded build
@colesbury colesbury deleted the gh-120974-asyncio-swap-current-task branch October 30, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colesbury @bedevere-bot @kumaraditya303
0