10000 gh-122255: Add black box tests in test_warnings by serhiy-storchaka · Pull Request #122227 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-122255: Add black box tests in test_warnings #122227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2024
Merged

gh-122255: Add black box tests in test_warnings #122227

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
680eaef
gh-86298: Add black box tests in test_warnings
serhiy-storchaka Jul 24, 2024
ef9cb0f
Test also with the Python implementation.
serhiy-storchaka Jul 24, 2024
6c73ece
Use "always" filter.
serhiy-storchaka Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test also with the Python implementation.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Jul 24, 2024
commit ef9cb0fb7af4816e46346e62c72c4365007a5f95
176 changes: 91 additions & 85 deletions Lib/test/test_warnings/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,97 @@ class NonWarningSubclass:
self.module.warn('good warning category', MyWarningClass)
self.assertIsInstance(cm.warning, Warning)

def check_module_globals(self, module_globals):
with original_warnings.catch_warnings(module=self.module, record=True) as w:
self.module.filterwarnings('default')
self.module.warn_explicit(
'eggs', UserWarning, 'bar', 1,
module_globals=module_globals)
self.assertEqual(len(w), 1)
self.assertEqual(w[0].category, UserWarning)
self.assertEqual(str(w[0].message), 'eggs')

def check_module_globals_error(self, module_globals, errmsg, errtype=ValueError):
if self.module is py_warnings:
self.check_module_globals(module_globals)
return
with original_warnings.catch_warnings(module=self.module, record=True) as w:
self.module.filterwarnings('default')
with self.assertRaisesRegex(errtype, re.escape(errmsg)):
self.module.warn_explicit(
'eggs', UserWarning, 'bar', 1,
module_globals=module_globals)
self.assertEqual(len(w), 0)

def check_module_globals_deprecated(self, module_globals, msg):
if self.module is py_warnings:
self.check_module_globals(module_globals)
return
with original_warnings.catch_warnings(module=self.module, record=True) as w:
self.module.filterwarnings('default')
self.module.warn_explicit(
'eggs', UserWarning, 'bar', 1,
module_globals=module_globals)
self.assertEqual(len(w), 2)
self.assertEqual(w[0].category, DeprecationWarning)
self.assertEqual(str(w[0].message), msg)
self.assertEqual(w[1].category, UserWarning)
self.assertEqual(str(w[1].message), 'eggs')

def test_gh86298_no_loader_and_no_spec(self):
self.check_module_globals({'__name__': 'bar'})

def test_gh86298_loader_is_none_and_no_spec(self):
self.check_module_globals({'__name__': 'bar', '__loader__': None})

def test_gh86298_no_loader_and_spec_is_none(self):
self.check_module_globals_error(
{'__name__': 'bar', '__spec__': None},
'Module globals is missing a __spec__.loader')

def test_gh86298_loader_is_none_and_spec_is_none(self):
self.check_module_globals_error(
{'__name__': 'bar', '__loader__': None, '__spec__': None},
'Module globals is missing a __spec__.loader')

def test_gh86298_loader_is_none_and_spec_loader_is_none(self):
self.check_module_globals_error(
{'__name__': 'bar', '__loader__': None,
'__spec__': types.SimpleNamespace(loader=None)},
'Module globals is missing a __spec__.loader')

def test_gh86298_no_spec(self):
self.check_module_globals_deprecated(
{'__name__': 'bar', '__loader__': object()},
'Module globals is missing a __spec__.loader')

def test_gh86298_spec_is_none(self):
self.check_module_globals_deprecated(
{'__name__': 'bar', '__loader__': object(), '__spec__': None},
'Module globals is missing a __spec__.loader')

def test_gh86298_no_spec_loader(self):
self.check_module_globals_deprecated(
{'__name__': 'bar', '__loader__': object(),
'__spec__': types.SimpleNamespace()},
'Module globals is missing a __spec__.loader')

def test_gh86298_loader_and_spec_loader_disagree(self):
self.check_module_globals_deprecated(
{'__name__': 'bar', '__loader__': object(),
'__spec__': types.SimpleNamespace(loader=object())},
'Module globals; __loader__ != __spec__.loader')

def test_gh86298_no_loader_and_no_spec_loader(self):
self.check_module_globals_error(
{'__name__': 'bar', '__spec__': types.SimpleNamespace()},
'Module globals is missing a __spec__.loader', AttributeError)

def test_gh86298_no_loader_with_spec_loader_okay(self):
self.check_module_globals(
{'__name__': 'bar',
'__spec__': types.SimpleNamespace(loader=object())})

class CWarnTests(WarnTests, unittest.TestCase):
module = c_warnings

Expand Down Expand Up @@ -955,91 +1046,6 @@ def test_issue31566(self):
support.swap_item(globals(), '__file__', None):
self.assertRaises(UserWarning, self.module.warn, 'bar')

def check_module_globals(self, module_globals):
with original_warnings.catch_warnings(module=self.module, record=True) as w:
self.module.filterwarnings('default')
self.module.warn_explicit(
'eggs', UserW 8000 arning, 'bar', 1,
module_globals=module_globals)
self.assertEqual(len(w), 1)
self.assertEqual(w[0].category, UserWarning)
self.assertEqual(str(w[0].message), 'eggs')

def check_module_globals_error(self, module_globals, errmsg, errtype=ValueError):
with original_warnings.catch_warnings(module=self.module, record=True) as w:
self.module.filterwarnings('default')
with self.assertRaisesRegex(errtype, re.escape(errmsg)):
self.module.warn_explicit(
'eggs', UserWarning, 'bar', 1,
module_globals=module_globals)
self.assertEqual(len(w), 0)

def check_module_globals_deprecated(self, module_globals, msg):
with original_warnings.catch_warnings(module=self.module, record=True) as w:
self.module.filterwarnings('default')
self.module.warn_explicit(
'eggs', UserWarning, 'bar', 1,
module_globals=module_globals)
self.assertEqual(len(w), 2)
self.assertEqual(w[0].category, DeprecationWarning)
self.assertEqual(str(w[0].message), msg)
self.assertEqual(w[1].category, UserWarning)
self.assertEqual(str(w[1].message), 'eggs')

def test_gh86298_no_loader_and_no_spec(self):
self.check_module_globals({'__name__': 'bar'})

def test_gh86298_loader_is_none_and_no_spec(self):
self.check_module_globals({'__name__': 'bar', '__loader__': None})

def test_gh86298_no_loader_and_spec_is_none(self):
self.check_module_globals_error(
{'__name__': 'bar', '__spec__': None},
'Module globals is missing a __spec__.loader')

def test_gh86298_loader_is_none_and_spec_is_none(self):
self.check_module_globals_error(
{'__name__': 'bar', '__loader__': None, '__spec__': None},
'Module globals is missing a __spec__.loader')

def test_gh86298_loader_is_none_and_spec_loader_is_none(self):
self.check_module_globals_error(
{'__name__': 'bar', '__loader__': None,
'__spec__': types.SimpleNamespace(loader=None)},
'Module globals is missing a __spec__.loader')

def test_gh86298_no_spec(self):
self.check_module_globals_deprecated(
{'__name__': 'bar', '__loader__': object()},
'Module globals is missing a __spec__.loader')

def test_gh86298_spec_is_none(self):
self.check_module_globals_deprecated(
{'__name__': 'bar', '__loader__': object(), '__spec__': None},
'Module globals is missing a __spec__.loader')

def test_gh86298_no_spec_loader(self):
self.check_module_globals_deprecated(
{'__name__': 'bar', '__loader__': object(),
'__spec__': types.SimpleNamespace()},
'Module globals is missing a __spec__.loader')

def test_gh86298_loader_and_spec_loader_disagree(self):
self.check_module_globals_deprecated(
{'__name__': 'bar', '__loader__': object(),
'__spec__': types.SimpleNamespace(loader=object())},
'Module globals; __loader__ != __spec__.loader')

def test_gh86298_no_loader_and_no_spec_loader(self):
self.check_module_globals_error(
{'__name__': 'bar', '__spec__': types.SimpleNamespace()},
'Module globals is missing a __spec__.loader', AttributeError)

def test_gh86298_no_loader_with_spec_loader_okay(self):
self.check_module_globals(
{'__name__': 'bar',
'__spec__': types.SimpleNamespace(loader=object())})


class WarningsDisplayTests(BaseTest):

Expand Down
0