8000 gh-119180: Improvements to ForwardRef.evaluate by JelleZijlstra · Pull Request #122210 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-119180: Improvements to ForwardRef.evaluate #122210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2024
Merged

gh-119180: Improvements to ForwardRef.evaluate #122210

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd45f42
gh-119180: Improvements to ForwardRef.evaluate
JelleZijlstra Jul 24, 2024
749ca9d
Fix test
JelleZijlstra Jul 24, 2024
2800902
Merge branch 'main' into pep649-tweaks
JelleZijlstra Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Jul 24, 2024
commit 749ca9d43c41863eac90f2e07639f9161b1990b1
4 changes: 4 additions & 0 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,10 @@ def _eval_type(t, globalns, localns, type_params=_sentinel, *, recursive_guard=f
_deprecation_warning_for_no_type_params_passed("typing._eval_type")
type_params = ()
if isinstance(t, ForwardRef):
# If the forward_ref has __forward_module__ set, evaluate() infers the globals
# from the module, and it will probably pick better than the globals we have here.
if t.__forward_module__ is not None:
globalns = None
return evaluate_forward_ref(t, globals=globalns, locals=localns,
type_params=type_params, owner=owner,
_recursive_guard=recursive_guard, format=format)
Expand Down
Loading
0