8000 [3.13] GH-122155: Fix cases generator to correctly compute 'peek' offset for error handling (GH-122158) by markshannon · Pull Request #122174 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.13] GH-122155: Fix cases generator to correctly compute 'peek' offset for error handling (GH-122158) #122174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2024
Merged

[3.13] GH-122155: Fix cases generator to correctly compute 'peek' offset for error handling (GH-122158) #122174

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a7484b
GH-122155: Fix cases generator to correctly compute 'peek' offset for…
markshannon Jul 23, 2024
5935132
Account for 3.13 differences in test results
markshannon Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Account for 3.13 differences in test results
  • Loading branch information
@markshannon
markshannon committed Jul 24, 2024
commit 5935132a199cb0a8638e300739032ff40c724023
13 changes: 6 additions & 7 deletions Lib/test/test_generated_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,12 +835,12 @@ def test_pop_on_error_peeks(self):
frame->instr_ptr = next_instr;
next_instr += 1;
INSTRUCTION_STATS(TEST);
_PyStackRef x;
_PyStackRef y;
_PyStackRef a;
_PyStackRef b;
_PyStackRef j;
_PyStackRef k;
PyObject *y;
PyObject *x;
PyObject *a;
PyObject *b;
PyObject *k;
PyObject *j;
// FIRST
y = stack_pointer[-1];
x = stack_pointer[-2];
Expand All @@ -858,7 +858,6 @@ def test_pop_on_error_peeks(self):
if (cond) goto pop_2_error;
}
stack_pointer += -2;
assert(WITHIN_STACK_BOUNDS());
DISPATCH();
}
"""
Expand Down
Loading
0