8000 gh-113977, gh-120754: Remove unbounded reads from zipfile by cmaloney · Pull Request #122101 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-113977, gh-120754: Remove unbounded reads from zipfile #122101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
< 8000 span class="sr-only">Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/zipfile/__init__.py
Co-authored-by: Daniel Hillier <daniel.hillier@gmail.com>
  • Loading branch information
cmaloney and danifus authored Jul 22, 2024
commit 8961b0b0a4dfdef1cf1b78fcb6575343015d1d84
2 changes: 1 addition & 1 deletion Lib/zipfile/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ def _EndRecData(fpin):
# number does not appear in the comment.
maxCommentStart = max(filesize - ZIP_MAX_COMMENT - sizeEndCentDir, 0)
fpin.seek(maxCommentStart, 0)
data = fpin.read(ZIP_MAX_COMMENT + sizeEndCentDir + 1)
data = fpin.read(ZIP_MAX_COMMENT + sizeEndCentDir)
start = data.rfind(stringEndArchive)
if start >= 0:
# found the magic number; attempt to unpack and interpret
Expand Down
Loading
0