8000 bpo-23205: IDLE: Add tests and refactor grep's findfiles by csabella · Pull Request #12203 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-23205: IDLE: Add tests and refactor grep's findfiles #12203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 23, 2019
Merged

bpo-23205: IDLE: Add tests and refactor grep's findfiles #12203

merged 7 commits into from
Mar 23, 2019

Conversation

csabella
Copy link
Contributor
@csabella csabella commented Mar 6, 2019 •
edited by bedevere-bot
Loading
  • Add tests for grep's findfiles.
  • Move findfiles from inside the GrepDialog class to be a module function.
  • Refactor findfiles to use os.walk.

Based on a patch by Al Sweigart.

https://bugs.python.org/issue23205

@csabella csabella requested a review from terryjreedy as a code owner March 6, 2019 20:05
terryjreedy
terryjreedy approved these changes Mar 23, 2019
View reviewed changes
Copy link
Member
@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ZackerySpytz
ZackerySpytz reviewed Mar 23, 2019
View reviewed changes
@csabella csabella merged commit d60f658 into python:master Mar 23, 2019
@miss-islington
Copy link
Contributor

Thanks @csabella for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@csabella csabella deleted the bpo23205 branch March 23, 2019 11:33
@miss-islington
Copy link
Contributor

Thanks @csabella for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-12512 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2019
@csabella @miss-islington
bpo-23205: IDLE: Add tests and refactor grep's findfiles (pythonGH-12203
eddf447 
)

* Add tests for grep findfiles.
* Move findfiles to module function.
* Change findfiles to use os.walk.

Based on a patch by Al Sweigart.
(cherry picked from commit d60f658)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Mar 23, 2019
@miss-islington @csabella
bpo-23205: IDLE: Add tests and refactor grep's findfiles (GH-12203)
5ab6650 
* Add tests for grep findfiles.
* Move findfiles to module function.
* Change findfiles to use os.walk.

Based on a patch by Al Sweigart.
(cherry picked from commit d60f658)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@csabella @miss-islington @bedevere-bot @terryjreedy @ZackerySpytz @the-knights-who-say-ni
0