8000 gh-122014: Account with abi_thread in test_sysconfig.test_user_similar (#122014) by befeleme · Pull Request #122017 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-122014: Account with abi_thread in test_sysconfig.test_user_similar (#122014) #122017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2024
Merged

gh-122014: Account with abi_thread in test_sysconfig.test_user_similar (#122014) #122017

merged 2 commits into from
Jul 19, 2024

Conversation

befeleme
Copy link
Contributor
@befeleme befeleme commented Jul 19, 2024 •
edited by bedevere-app bot
Loading

@befeleme befeleme requested a review from FFY00 as a code owner July 19, 2024 09:25
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Jul 19, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 19, 2024
Closed
@hroncok
Copy link
Contributor
hroncok commented Jul 19, 2024 •
edited
Loading

I get AttributeError: module 'sysconfig' has no attribute '_get_python_version_abi'. Did you mean: 'get_python_version'? when running the test directly from your branch. But the test passes when rebased (trivially) onto main.

hroncok pushed a commit to fedora-python/cpython that referenced this pull request Jul 19, 2024
@befeleme @hroncok
00432: Account with abi_thread in test_sysconfig.test_user_similar
5e4b8e9 
From python#122017
@corona10 corona10 requested a review from colesbury July 19, 2024 11:30
@colesbury colesbury added skip news needs backport to 3.13 bugs and security fixes labels Jul 19, 2024
@colesbury
Copy link
Contributor

!buildbot Fedora Rawhide NoGIL

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 49d1a33 🤖

The command will test the builders whose names match following regular expression: Fedora Rawhide NoGIL

The builders matched are:

  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Rawhide NoGIL PR
  • AMD64 Fedora Rawhide NoGIL PR
  • aarch64 Fedora Rawhide NoGIL PR

colesbury
colesbury reviewed Jul 19, 2024
View reviewed changes
@colesbury colesbury enabled auto-merge (squash) July 19, 2024 16:23
@colesbury colesbury merged commit 186b4d8 into python:main Jul 19, 2024
31 checks passed
@miss-islington-app
Copy link

Thanks @befeleme for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@befeleme @miss-islington
pythongh-122014: Account for abi_thread in test_sysconfig.test_user_s…
5bc9c98 
…imilar (pythongh-122017)

(cherry picked from commit 186b4d8)

Co-authored-by: Karolina Surma <33810531+befeleme@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Jul 19, 2024

GH-122039 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2024
colesbury pushed a commit that referenced this pull request Jul 19, 2024
@miss-islington @befeleme
[3.13] gh-122014: Account for abi_thread in test_sysconfig.test_user_…
e881145 
…similar (gh-122017) (#122039)

(cherry picked from commit 186b4d8)

Co-authored-by: Karolina Surma <33810531+befeleme@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@hroncok hroncok hroncok approved these changes

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@befeleme @hroncok @colesbury @bedevere-bot
0