8000 Fix cache restoration for Hypothesis CI job by webknjaz · Pull Request #121756 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Fix cache restoration for Hypothesis CI job #121756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Fix cache restoration for Hypothesis CI job #121756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
🧪🚑 Fix cache restoration @ Hypothesis CI job 
Previously, the CI workflow job running Hypothesis was mistakenly set
up to use a cache restoration key prefixed with a leading
hyphen [[1]]. This was done in an attempt to figure out the right
format for the `actions/cache` input argument called `restore-keys`
as the official examples tend to be confusing [[2]].

This results no cache being found for the Hypothesis database on
lookup [[3]] and the logs contain the following:

    Cache not found for input keys: hypothesis-database-9927179210, - hypothesis-database-

The patch corrects that by dropping the unintended characters from the
catch-all cache key.

[1]: ccbb010#r1677102123
[2]: actions/cache#1173
[3]: https://github.com/python/cpython/actions/runs/9927179210/job/27421821417#step:21:24
  • Loading branch information
@webknjaz
webknjaz committed Jul 14, 2024
commit 3446d529d2d1487724362a345ff03fe473f8dffe
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ jobs:
path: ${{ env.CPYTHON_BUILDDIR }}/.hypothesis/
key: hypothesis-database-${{ github.head_ref || github.run_id }}
restore-keys: |
- hypothesis-database-
hypothesis-database-
- name: "Run tests"
working-directory: ${{ env.CPYTHON_BUILDDIR }}
run: |
Expand Down
Loading
0